Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSC] conform with markdown rules (GSMA compatibility) #2603

Closed
collivier opened this issue Sep 3, 2021 · 23 comments · Fixed by #2678
Closed

[TSC] conform with markdown rules (GSMA compatibility) #2603

collivier opened this issue Sep 3, 2021 · 23 comments · Fixed by #2678
Labels
Backlog bug Something isn't working New

Comments

@collivier
Copy link
Collaborator

collivier commented Sep 3, 2021

GSMA leverages pandoc to convert all CNTT chapters to docx.
Even if the results seem globally ok, a couple of rules would avoid a few manual processing steps.
It's worth mentioning that it obscures any git diff and then makes GSMA updates very difficult

A first set of rules we do apply as soon as possible:

  • not to mix html and markdown which could be considered as fine just in GitHub but it's incorrect from a markdown pov (see anchors and images).
  • to remove all manual title numberings (in markdown we do only leverage #, ## or ###)
  • to remove all our TOCs (it should be rather part of pandoc processing)
  • to avoid complex tables as much as possible (MD only accepts basic tabs)
  • to modify images rather than applying CSS on it
@CsatariGergely
Copy link
Collaborator

  • Images are embedded with html as markdown does not support image scaling. To overcome this we would need to manually scale all images. Are we ready to do that?
  • Anchors are used to mask the difference between the auto anchor generation of GitHub and ReadTheDocs. We use these in a very inconsistent way anyways, so I would be happy to see a generic solution.
  • If we remove the ToC-s we will need to generate them during the ReadTheDocs build.
  • On complex tabs you mean complex tables?

@CsatariGergely
Copy link
Collaborator

Pulling in @bfcohen and @scottsteinbrueck as acting doc ptl-s.

@collivier
Copy link
Collaborator Author

Yes my point is to scale the src image rather than leveraging html (somehow we don't have any other choice)
I could have a look if Sphinx is able to generate TOC (I would bet yet without any doubt :))

Yes complex tables :) fixing the issue messages...

@collivier
Copy link
Collaborator Author

I think we would have to remove all br, li, etc. used in cells too (see RA2) => to compact in a single line?.

@gkunz
Copy link
Collaborator

gkunz commented Sep 3, 2021

Pulling in @bfcohen and @scottsteinbrueck as acting doc ptl-s.

Adding @ss8171 Scot Steele

@tomkivlin
Copy link
Collaborator

I could have a look if Sphinx is able to generate TOC (I would bet yet without any doubt :))

Yes, it can but how it looks depends on the theme - we use Sphinx with a Material for Sphinx theme in VF and the ToC appears in a pane on the right rather than at the top of each page.

@collivier
Copy link
Collaborator Author

I would consider the theme issue as minor compared to the current numbering which is manual and even false in RC1.
And pandoc adds its own for each title.

@collivier
Copy link
Collaborator Author

collivier commented Sep 3, 2021

+ funny thread before weekend.
markdown format seems more what we need (alt vs figcaption).

cedric@dev:~$ echo \![img]\(img1.jpg\) | pandoc -f markdown
<figure>
<img src="img1.jpg" alt="" /><figcaption>img</figcaption>
</figure>
cedric@dev:~$ echo \![img]\(img1.jpg\) | pandoc -f gfm
<p><img src="img1.jpg" alt="img" /></p>
cedric@dev:~$ 

collivier added a commit to collivier/CNTT that referenced this issue Sep 5, 2021
@CsatariGergely
Copy link
Collaborator

Notes about the topic from the Weekly Technical Meeting are here.

collivier added a commit to collivier/CNTT that referenced this issue Oct 14, 2021
collivier added a commit that referenced this issue Oct 14, 2021
#2603

Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
collivier added a commit to collivier/CNTT that referenced this issue Oct 14, 2021
collivier added a commit that referenced this issue Oct 14, 2021
* [RC1][RC2] Rather leverage markdown for images

#2603

Signed-off-by: Cédric Ollivier <[email protected]>

* Update the NFVI Profile and the associated diagram

#2611

Co-Authored-By: Pankaj Goyal <[email protected]>
Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
Co-authored-by: Pankaj Goyal <[email protected]>
gkunz added a commit to gkunz/CNTT that referenced this issue Nov 3, 2021
walterkozlowski pushed a commit that referenced this issue Nov 15, 2021
* [RI2] proofreading and removal of some HTML tags

Partially closes #2603

Signed-off-by: Georg Kunz <[email protected]>

* Adding width to figures for future rst conversion

Co-authored-by: Gergely Csatari <[email protected]>

* using term Anuket Assured Program

Signed-off-by: Georg Kunz <[email protected]>

Co-authored-by: Gergely Csatari <[email protected]>
gkunz pushed a commit to gkunz/CNTT that referenced this issue Jan 19, 2022
gkunz pushed a commit to gkunz/CNTT that referenced this issue Jan 19, 2022
* [RC1][RC2] Rather leverage markdown for images

anuket-project#2603

Signed-off-by: Cédric Ollivier <[email protected]>

* Update the NFVI Profile and the associated diagram

anuket-project#2611

Co-Authored-By: Pankaj Goyal <[email protected]>
Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
Co-authored-by: Pankaj Goyal <[email protected]>
gkunz added a commit to gkunz/CNTT that referenced this issue Jan 19, 2022
* [RI2] proofreading and removal of some HTML tags

Partially closes anuket-project#2603

Signed-off-by: Georg Kunz <[email protected]>

* Adding width to figures for future rst conversion

Co-authored-by: Gergely Csatari <[email protected]>

* using term Anuket Assured Program

Signed-off-by: Georg Kunz <[email protected]>

Co-authored-by: Gergely Csatari <[email protected]>
collivier added a commit to collivier/cntt-rc2 that referenced this issue Oct 1, 2023
collivier added a commit to collivier/cntt-rc2 that referenced this issue Oct 1, 2023
anuket-project/anuket-specifications#2603

Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
collivier added a commit to collivier/cntt-rc2 that referenced this issue Oct 1, 2023
collivier added a commit to collivier/cntt-rc2 that referenced this issue Oct 1, 2023
* [RC1][RC2] Rather leverage markdown for images

anuket-project/anuket-specifications#2603

Signed-off-by: Cédric Ollivier <[email protected]>

* Update the NFVI Profile and the associated diagram

anuket-project/anuket-specifications#2611

Co-Authored-By: Pankaj Goyal <[email protected]>
Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
Co-authored-by: Pankaj Goyal <[email protected]>
collivier added a commit to anuket-project/RC1 that referenced this issue Dec 10, 2023
collivier added a commit to anuket-project/RC1 that referenced this issue Dec 10, 2023
anuket-project/anuket-specifications#2603

Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
collivier added a commit to anuket-project/RC1 that referenced this issue Dec 10, 2023
collivier added a commit to anuket-project/RC1 that referenced this issue Dec 10, 2023
* [RC1][RC2] Rather leverage markdown for images

anuket-project/anuket-specifications#2603

Signed-off-by: Cédric Ollivier <[email protected]>

* Update the NFVI Profile and the associated diagram

anuket-project/anuket-specifications#2611

Co-Authored-By: Pankaj Goyal <[email protected]>
Signed-off-by: Cédric Ollivier <[email protected]>

Co-authored-by: Cédric Ollivier <[email protected]>
Co-authored-by: Pankaj Goyal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment