Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permanent link icon is broken after Sphinx upgrade #46170

Open
1 of 2 tasks
jedcunningham opened this issue Jan 28, 2025 · 4 comments
Open
1 of 2 tasks

Permanent link icon is broken after Sphinx upgrade #46170

jedcunningham opened this issue Jan 28, 2025 · 4 comments

Comments

@jedcunningham
Copy link
Member

What do you see as an issue?

After upgrading our version of Sphinx in #45563, the permanent link icon is now broken.

Before:

Image

Currently:

Image

Solving the problem

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@eladkal
Copy link
Contributor

eladkal commented Jan 28, 2025

cc @shahar1

@shahar1
Copy link
Contributor

shahar1 commented Jan 28, 2025

cc @shahar1

@jscheffl do you know how to handle it?

@jscheffl
Copy link
Contributor

In older Sphinx versions (or any extra, have no deep insight) there was an SVG rendering the link. After upgrading the SVG was "gone" so could not adjust the template to the icon/image. Therefore to make it to main I replaced it with the text.

Feel free to find the bug in the theme or extend it, Otherwise we need to live with it.

@potiuk
Copy link
Member

potiuk commented Jan 29, 2025

I think the SVG was gone because we tested it in test environment where CSP (Content Security Policy) was set - and we had to fix few other things (for example we had to download all images of committers from GitHub to be embedded in our website. A ND we should do the same in this case. this SVG has to come from our static folder. That should fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants