[EPIC] Port object_store content from arrow-rs repository #2
Comments
|
I will begin moving the code now |
* Implement bulk_delete_request for Azure * Fix lint and add Azurite bug workaround * Special 404 error case * Clippy fix * Make number of expected headers more conservative and better document invariants * Use multer for multipart parsing * Fix clippy * Fix clippy apache#2 * Reuse part response buffer * Make multer conditional to azure feature * One more HeaderValue::from_static * Add tests for bulk delete request building and response parsing * Switch back to manual parsing to avoid multer dependency, other PR suggestions * Fixes lint
|
@alamb do you want to move only open issues or closed issues as well? Caveat, if a label on an issue doesn't exists in the target repo it is dropped. I have done this for go and java with the |
Moving closed issues would be amazing. @assignUser do you have the scripts you used (or can you point me at them) for how you migrated the issues using |
gh issue list -R apache/arrow-rs --label "object-store" -L 1000 --state "all" --json 'number' -q '.[].number' | xargs -I% gh issue transfer % https://github.com/apache/arrow-rs-object-storeThis will transfer all 248 issues with the "object-store" label to this repo. Any references to these issues in PRs etc. will break afaik. As we have those in commit messages in the monorepo we only transfered open issues but from what I can see this is not the case for you. They will also be re-numbered |
|
Thanks @assignUser I ran the following commands: And spot checked a few random numbers in to make sure they were actually issues with object store (which they were)
Which look good I am now goign to play around with a few tests issues and see how the process works $ cat test_issues.txt
2561
2550
2373
2361 |
|
To test it I did the following to move one ticket: Leave a comment Then I ran this to move the actual ticket And the new location looks good: I also verified that the old URL still works: I will now try with a few more and if they look good I'll migrate them all |
|
Thanks for your help @assignUser -- the commands seem to have worked great! |
|
Happy to help :)
Oh cool I didn't know that! |
|
I think we should also remove "object store" from the issues. |
Thanks @ByteBaker -- do you mean remove the object_store label? |
@alamb No. I didn't see any labels to begin with. I was referring to the issue titles. E.g.: You'd notice a lot of issues have this or simply the two words |
|
Here is a script that'll re-title those issues: gh issue list -R apache/arrow-rs-object-store -L 400 --json 'title,number' -q '[.[] | select(.title | test("^\\[?object[-_ ]?store\\]?:?.*"; "i"))] | .[].title |= sub("^\\[?object[-_ ]?store\\]?:? *"; ""; "i")| .[]| [.number, .title] | @tsv' |
while IFS=$'\t' read -r number title; do
gh issue edit -R apache/arrow-rs-object-store "$number" -t "$title"
done |
Cool -- yeah if someone wants to run that it is cool. I don't mind the redundancy -- maybe someone can find time to go through the tickets manually sometime and close ones / clean them up if they don't make sense |
|
@alamb I'd be happy to, but I don't have the right access. |
|
Thanks @ByteBaker |
Ohh, I meant I can't modify since I don't have permissions. 😅 @alamb |
|
I think this issue is now done 🎉 Thanks everyone |
alamb
added
the
development-process
object_storeto its own github repo? arrow-rs#6183This epic tracks the items needed to move the object_store code from https://github.com/apache/arrow-rs to this repo
object_storeto this repo, preserving history: Importobject_store, with history, from arrow-rs #3.githubtemplates and checks to arrow-rs-object-store crate #4object_storefrom arrow-rs repository arrow-rs#7316The text was updated successfully, but these errors were encountered: