Skip to content

Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public #7438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
masonh22 opened this issue Apr 23, 2025 · 1 comment · May be fixed by #7440
Open

Move parquet::file::metadata::reader::FooterTail to parquet::file::metadata so that it is public #7438

masonh22 opened this issue Apr 23, 2025 · 1 comment · May be fixed by #7440
Assignees
@masonh22
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@masonh22
Copy link

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

ParquetMetaDataReader::decode_footer was deprecated in favor of ParquetMetaDataReader::decode_footer_tail, which returns a Result<FooterTail>. FooterTail is declared public, but the module it's defined in is not public. This seems to be an oversight, because it means that FooterTail is effectively private, making decode_footer_tail useless.

Describe the solution you'd like

Move the FooterTail definition to parquet/file/metadata/mod.rs, or have that file pub use it.

Describe alternatives you've considered

Additional context
@masonh22 masonh22 added the enhancement Any new improvement worthy of a entry in the changelog label Apr 23, 2025
@masonh22
Copy link
Author

take

@masonh22 masonh22 linked a pull request Apr 23, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masonh22 masonh22

Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make FooterTail public masonh22/arrow-rs
1 participant
@masonh22