[Bug]: start-build-end.sh fails with go.mod file not found

[thomas-flynn-ingka]

What happened?

I cloned the repository, ran start-build-env.sh and after a while it fails with

=> ERROR [7/8] RUN go get github.com/linkedin/goavro/v2 0.1s

[7/8] RUN go get github.com/linkedin/goavro/v2:
0.134 go: go.mod file not found in current directory or any parent directory.
0.134 'go get' is no longer supported outside a module.
0.134 To build and install a command, use 'go install' with a version,
0.134 like 'go install example.com/cmd@latest'
0.134 For more information, see https://golang.org/doc/go-get-install-deprecation
0.134 or run 'go help get' or 'go help install'.

---

Dockerfile:10

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

• Component: Python SDK
• Component: Java SDK
• Component: Go SDK
• Component: Typescript SDK
• Component: IO connector
• Component: Beam examples
• Component: Beam playground
• Component: Beam katas
• Component: Website
• Component: Spark Runner
• Component: Flink Runner
• Component: Samza Runner
• Component: Twister2 Runner
• Component: Hazelcast Jet Runner
• Component: Google Cloud Dataflow Runner

[mohamedawnallah]

.take-issue

[leo9827]

I try to do this and it works:
first, comment 'RUN go get github.com/linkedin/goavro/v2' in start-build-env.sh
second, run start-build-env.sh
now, if there dont have other questions you will in [Beam Build Env]:~/beam
and then do this:

cd $GOPATH && go get github.com/linkedin/goavro/v2 && cd -

it will download the package: github.com/linkedin/goavro/v2 in ./pkg/mod/github

---

I try to add this to start-build-env.sh's Dockerfile content but it's not working:

...
ENV GOPATH ${DOCKER_HOME_DIR}/beam/sdks/go/examples/.gogradle/project_gopath
# switch to GOPATH to run go get command
WORKDIR ${DOCKER_HOME_DIR}/beam/sdks/go/examples/.gogradle/project_gopath/src
COPY . .
# This next command still runs as root causing the ~/.cache/go-build to be owned by root
RUN go get github.com/linkedin/goavro/v2
...

[dev-mohit06]

hey @lostluck, can you assign that issue to me?

[lostluck]

Done, but you should be able to comment '.take-issue' to get the bot to to assign you to it.

See
https://github.com/apache/beam/blob/master/CONTRIBUTING.md#share-your-intent

Please do ping me if you have other questions though.

[dev-mohit06]

Right now, I don’t have any, but please accept my LinkedIn request. It’s Mohit Paddhariya https://linkedin.com/in/mohit-paddhariya. It helps me a lot in the software development world, as I am a bachelor from Bangalore. Thanks! ☺️

[dev-mohit06]

.take-issue

[mohamedawnallah]

Hi @lostluck,

It looks like this issue was already resolved by PR #33401.

EDIT: I just ran start-build-end.sh, and it worked fine.

[lostluck]

Works for me. Thanks for confirming!