Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Re-Enable testPy39embeddingsMLTransform in the Python Dependency Postcommit #32965

Closed
1 of 17 tasks
jrmccluskey opened this issue Oct 29, 2024 · 3 comments · Fixed by #33668
Closed
1 of 17 tasks

Comments

@jrmccluskey
Copy link
Contributor

What needs to happen?

The python dependency postcommit suite went perma-red because of a strange failure to find the sentence-transformers package in HF embeddings tests despite pip showing version 2.2.2 installed. The test should be re-enabled once the problem is resolved.

Issue Priority

Priority: 2 (default / most normal work should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@liferoad
Copy link
Contributor

>>> from sentence_transformers import SentenceTransformer
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/local/google/home/xqhu/Dev/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-embeddings/py39-embeddings/lib/python3.9/site-packages/sentence_transformers/__init__.py", line 3, in <module>
    from .datasets import SentencesDataset, ParallelSentencesDataset
  File "/usr/local/google/home/xqhu/Dev/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-embeddings/py39-embeddings/lib/python3.9/site-packages/sentence_transformers/datasets/__init__.py", line 3, in <module>
    from .ParallelSentencesDataset import ParallelSentencesDataset
  File "/usr/local/google/home/xqhu/Dev/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-embeddings/py39-embeddings/lib/python3.9/site-packages/sentence_transformers/datasets/ParallelSentencesDataset.py", line 4, in <module>
    from .. import SentenceTransformer
  File "/usr/local/google/home/xqhu/Dev/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-embeddings/py39-embeddings/lib/python3.9/site-packages/sentence_transformers/SentenceTransformer.py", line 12, in <module>
    from huggingface_hub import HfApi, HfFolder, Repository, hf_hub_url, cached_download
ImportError: cannot import name 'cached_download' from 'huggingface_hub' (/usr/local/google/home/xqhu/Dev/beam/sdks/python/test-suites/tox/py39/build/srcs/sdks/python/target/.tox-py39-embeddings/py39-embeddings/lib/python3.9/site-packages/huggingface_hub/__init__.py)

@liferoad
Copy link
Contributor

(py39-embeddings) xqhu@xqhu ~/Dev/beam$ pip list | grep sentence                                                    
sentence-transformers                 2.2.2
sentencepiece                         0.2.0

@liferoad
Copy link
Contributor

caused by easydiffusion/easydiffusion#1851 (comment)

the cached_download() function has been fully removed.

https://github.com/huggingface/huggingface_hub/releases/tag/v0.26.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants