Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UnboundedSourceAsSdfWrapperFn to share the cache across instances. #33901

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scwhittle
Copy link
Contributor

Add a utility class to enable sharing across all deserialized instances of a DoFn and use it in UnboundedSourceAsSdfWrapperFn to cache Readers across dofn instances.

fixes #32968

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…es of a DoFn and use it in UnboundedSourceAsSdfWrapperFn to cache Readers across dofn instances
@scwhittle scwhittle requested a review from kennknowles February 6, 2025 14:48
@github-actions github-actions bot added the java label Feb 6, 2025
@scwhittle
Copy link
Contributor Author

R: @kennknowles

I don't really like the utility class name, let me know if you have some better idea. It seems like this could be a common use within DoFns. For example, @sjvanrossum made me think of this concern in his work on Kafka source in #32986

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UnboundedSourceAsSDFWrapperFn caches readers per DoFn instance
1 participant