Use lock in FileSystems to allow only one thread to update options #34007
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
| SCHEME_TO_FILESYSTEM.set(verifySchemesAreUnique(options, registrars)); | ||
| return; | ||
| synchronized (lock) { | ||
| if (FILESYSTEM_REVISION.compareAndSet(revision, KV.of(id, nextRevision))) { |
There was a problem hiding this comment.
can we get rid of the atomic filesystem revision if we're synchronizing? It's complicated to think through possible timings
There was a problem hiding this comment.
@kennknowles what do you think about this? is it safe to remove atomic from FILESYSTEM_REVISION?
|
#34011 to fix test failure |
|
There is already a fix in #32723. For usage outside worker, one should call FileSystems.registerFileSystemsOnce which is already a synchronized method. |
Close my PR then. |
Fix #33965
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.