Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

增加协议不修改已有协议的值 #460

Open
Redfriday opened this issue Aug 22, 2018 · 2 comments
Open

增加协议不修改已有协议的值 #460

Redfriday opened this issue Aug 22, 2018 · 2 comments
Labels
enhancement improvements on existing features official created by brpc authors

Comments

@Redfriday
Copy link

目前brpc增加了thrift Protocol，但是这个Protocol是插入在Protocol num中间了，改变了以前协议的num值，可能会让使用动态库的场景向前兼容失效。一般我们会把动态库的更新和可执行程序（服务）的更新分开，这样如果协议enum值改了，我们只更新了程序或者只更新了brpc库，都会导致.h和.so里的enum值对不上，而在这样的情况下，保证.so和程序同时更新又很困难。

  • PROTOCOL_REDIS = 17,
  • PROTOCOL_MEMCACHE = 18,
  • PROTOCOL_REDIS = 16,
  • PROTOCOL_MEMCACHE = 17,
@jamesge
Copy link
Contributor

jamesge commented Aug 22, 2018

协议这个具体case是可以解决的。但是so这种模式就是要求ABI兼容，恐怕是难以做到的。

@jamesge
Copy link
Contributor

jamesge commented Aug 23, 2018 via email

@stale stale bot added the wontfix Not belonging to other labels label Sep 22, 2018
@apache apache deleted a comment from stale bot Sep 27, 2018
@stale stale bot removed the wontfix Not belonging to other labels label Sep 27, 2018
@jamesge jamesge added the official created by brpc authors label Sep 27, 2018
@jamesge jamesge changed the title 协议增加没有向前兼容 增加协议不修改已有协议的值 Sep 27, 2018
@jamesge jamesge added the enhancement improvements on existing features label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement improvements on existing features official created by brpc authors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jamesge @Redfriday