Drop support for Python 3.8

Python 3.8 is no longer maintained upstream and some Python packages
have dropped support for it.

Author: juergbi

.github/common.env

@@ -1,6 +1,6 @@
 # Shared common variables
 
 CI_IMAGE_VERSION=master-1558808360
-CI_TOXENV_MAIN=py38,py39,py310,py311,py312
-CI_TOXENV_PLUGINS=py38-plugins,py39-plugins,py310-plugins,py311-plugins,py312-plugins
+CI_TOXENV_MAIN=py39,py310,py311,py312
+CI_TOXENV_PLUGINS=py39-plugins,py310-plugins,py311-plugins,py312-plugins
 CI_TOXENV_ALL="${CI_TOXENV_MAIN},${CI_TOXENV_PLUGINS}"

.github/compose/ci.docker-compose.yml

@@ -90,11 +90,6 @@ services:
   # on the PyPA official 'manylinux' images that define the base ABI for
   # Python binary packages.
 
-  wheels-manylinux_2_28-cp38:
-    <<: *tests-template
-    image: quay.io/pypa/manylinux_2_28_x86_64
-    command: .github/wheel-helpers/test-wheel-manylinux.sh cp38 /opt/python/cp38-cp38/bin/python3
-
   wheels-manylinux_2_28-cp39:
     <<: *tests-template
     image: quay.io/pypa/manylinux_2_28_x86_64

.github/workflows/ci.yml

@@ -142,7 +142,6 @@ jobs:
         # The names here should map to a valid service defined in
         # "../compose/ci.docker-compose.yml"
         test-name:
-          - wheels-manylinux_2_28-cp38
           - wheels-manylinux_2_28-cp39
           - wheels-manylinux_2_28-cp310
           - wheels-manylinux_2_28-cp311

.github/workflows/release.yml

@@ -86,7 +86,6 @@ jobs:
         # The names here should map to a valid service defined in
         # "../compose/ci.docker-compose.yml"
         test-name:
-          - wheels-manylinux_2_28-cp38
           - wheels-manylinux_2_28-cp39
           - wheels-manylinux_2_28-cp310
           - wheels-manylinux_2_28-cp311

doc/source/hacking/using_the_testsuite.rst

@@ -68,14 +68,14 @@ found on your host. If you have multiple python versions installed, you may
 want to run tests against only one version and you can do that using the ``-e``
 option when running tox::
 
-  tox -e py37
+  tox -e py312
 
 If you would like to test and lint at the same time, or if you do have multiple
 python versions installed and would like to test against multiple versions, then
 we recommend using `detox <https://github.com/tox-dev/detox>`_, just run it with
 the same arguments you would give `tox`::
 
-  detox -e lint,py36,py37
+  detox -e lint,py311,py312
 
 The output of all failing tests will always be printed in the summary, but
 if you want to observe the stdout and stderr generated by a passing test,

doc/source/main_install.rst

@@ -35,7 +35,7 @@ Runtime requirements
 
 BuildStream requires the following Python environment to run:
 
-- python3 >= 3.8
+- python3 >= 3.9
 - PyPI packages as specified in
   `requirements.in <https://github.com/apache/buildstream/blob/master/requirements/requirements.in>`_.
 

pyproject.toml

@@ -53,9 +53,10 @@ environment = { BST_BUNDLE_BUILDBOX = "1" }
 manylinux-x86_64-image = "manylinux_2_28"
 
 skip = [
-  # BuildStream supports Python >= 3.8
+  # BuildStream supports Python >= 3.9
   "cp36-*",
   "cp37-*",
+  "cp38-*",
   # PyPy may work, but nobody is testing it so avoid distributing prebuilt binaries.
   "pp*",
   # Skipping this niche archicture ~halves overall build time.

setup.py

@@ -44,10 +44,10 @@
 # Python requirements
 ##################################################################
 REQUIRED_PYTHON_MAJOR = 3
-REQUIRED_PYTHON_MINOR = 8
+REQUIRED_PYTHON_MINOR = 9
 
 if sys.version_info[0] != REQUIRED_PYTHON_MAJOR or sys.version_info[1] < REQUIRED_PYTHON_MINOR:
-    print("BuildStream requires Python >= 3.8")
+    print("BuildStream requires Python >= 3.9")
     sys.exit(1)
 
 try:
@@ -367,7 +367,6 @@ def files_from_module(modname):
         "License :: OSI Approved :: Apache Software License",
         "Operating System :: POSIX",
         "Programming Language :: Python :: 3",
-        "Programming Language :: Python :: 3.8",
         "Programming Language :: Python :: 3.9",
         "Programming Language :: Python :: 3.10",
         "Programming Language :: Python :: 3.11",

src/buildstream/plugin.py

@@ -158,12 +158,7 @@
 _FILE = Union[None, int, IO[Any]]
 _TXT = Union[bytes, str]
 _STR_BYTES_PATH = Union[str, bytes, "os.PathLike[str]", "os.PathLike[bytes]"]
-if sys.version_info >= (3, 8):
-    _CMD = Union[_STR_BYTES_PATH, Sequence[_STR_BYTES_PATH]]
-else:
-    # Python 3.6 doesn't support _CMD being a single PathLike.
-    # See: https://bugs.python.org/issue31961
-    _CMD = Union[_TXT, Sequence[_STR_BYTES_PATH]]
+_CMD = Union[_STR_BYTES_PATH, Sequence[_STR_BYTES_PATH]]
 
 # _background_job_wrapper()
 #

tox.ini

@@ -16,7 +16,7 @@
 # Tox global configuration
 #
 [tox]
-envlist = py{38,39,310,311,312}
+envlist = py{39,310,311,312}
 skip_missing_interpreters = true
 isolated_build = true
 
@@ -33,30 +33,30 @@ BST_PLUGINS_VERSION = db71610b7ae9884f6d8cbe0d3cc5a1c657c19edb # 2.2.0
 [testenv]
 usedevelop =
     # This is required by Cython in order to get coverage for cython files.
-    py{38,39,310,311,312}-!nocover: True
+    py{39,310,311,312}-!nocover: True
 
 commands =
     # Running with coverage reporting enabled
-    py{38,39,310,311,312}-!plugins-!nocover: pytest --basetemp {envtmpdir} --cov=buildstream --cov-config .coveragerc {posargs}
+    py{39,310,311,312}-!plugins-!nocover: pytest --basetemp {envtmpdir} --cov=buildstream --cov-config .coveragerc {posargs}
     # Running with coverage reporting disabled
-    py{38,39,310,311,312}-!plugins-nocover: pytest --basetemp {envtmpdir} {posargs}
+    py{39,310,311,312}-!plugins-nocover: pytest --basetemp {envtmpdir} {posargs}
     # Running external plugins tests with coverage reporting enabled
-    py{38,39,310,311,312}-plugins-!nocover: pytest --basetemp {envtmpdir} --cov=buildstream --cov-config .coveragerc --plugins {posargs}
+    py{39,310,311,312}-plugins-!nocover: pytest --basetemp {envtmpdir} --cov=buildstream --cov-config .coveragerc --plugins {posargs}
     # Running external plugins tests with coverage disabled
-    py{38,39,310,311,312}-plugins-nocover: pytest --basetemp {envtmpdir} --plugins {posargs}
+    py{39,310,311,312}-plugins-nocover: pytest --basetemp {envtmpdir} --plugins {posargs}
 commands_post:
-    py{38,39,310,311,312}-!nocover: mkdir -p .coverage-reports
-    py{38,39,310,311,312}-!nocover: mv {envtmpdir}/.coverage {toxinidir}/.coverage-reports/.coverage.{env:COVERAGE_PREFIX:}{envname}
+    py{39,310,311,312}-!nocover: mkdir -p .coverage-reports
+    py{39,310,311,312}-!nocover: mv {envtmpdir}/.coverage {toxinidir}/.coverage-reports/.coverage.{env:COVERAGE_PREFIX:}{envname}
 deps =
-    py{38,39,310,311,312}: -rrequirements/requirements.txt
-    py{38,39,310,311,312}: -rrequirements/dev-requirements.txt
-    py{38,39,310,311,312}: git+https://github.com/apache/buildstream-plugins.git@{env:BST_PLUGINS_VERSION:{[config]BST_PLUGINS_VERSION}}
+    py{39,310,311,312}: -rrequirements/requirements.txt
+    py{39,310,311,312}: -rrequirements/dev-requirements.txt
+    py{39,310,311,312}: git+https://github.com/apache/buildstream-plugins.git@{env:BST_PLUGINS_VERSION:{[config]BST_PLUGINS_VERSION}}
 
     # Install local sample plugins for testing pip plugin origins
-    py{38,39,310,311,312}: {toxinidir}/tests/plugins/sample-plugins
+    py{39,310,311,312}: {toxinidir}/tests/plugins/sample-plugins
 
     # Install external plugins for plugin tests
-    py{38,39,310,311,312}-plugins: git+https://gitlab.com/buildstream/buildstream-plugins-community.git@{env:BST_PLUGINS_COMMUNITY_VERSION:{[config]BST_PLUGINS_COMMUNITY_VERSION}}#egg=bst_plugins_community[deb]
+    py{39,310,311,312}-plugins: git+https://gitlab.com/buildstream/buildstream-plugins-community.git@{env:BST_PLUGINS_COMMUNITY_VERSION:{[config]BST_PLUGINS_COMMUNITY_VERSION}}#egg=bst_plugins_community[deb]
 
     # Only require coverage and pytest-cov when using it
     !nocover: -rrequirements/cov-requirements.txt
@@ -84,21 +84,18 @@ passenv =
 # These keys are not inherited by any other sections
 #
 setenv =
-    py{38,39,310,311,312}: COVERAGE_FILE = {envtmpdir}/.coverage
-    py{38,39,310,311,312}: BST_TEST_HOME = {envtmpdir}
-    py{38,39,310,311,312}: BST_TEST_XDG_CACHE_HOME = {envtmpdir}/cache
-    py{38,39,310,311,312}: BST_TEST_XDG_CONFIG_HOME = {envtmpdir}/config
-    py{38,39,310,311,312}: BST_TEST_XDG_DATA_HOME = {envtmpdir}/share
-
-    # This is required to run tests with python 3.7
-    py37: SETUPTOOLS_ENABLE_FEATURES = "legacy-editable"
+    py{39,310,311,312}: COVERAGE_FILE = {envtmpdir}/.coverage
+    py{39,310,311,312}: BST_TEST_HOME = {envtmpdir}
+    py{39,310,311,312}: BST_TEST_XDG_CACHE_HOME = {envtmpdir}/cache
+    py{39,310,311,312}: BST_TEST_XDG_CONFIG_HOME = {envtmpdir}/config
+    py{39,310,311,312}: BST_TEST_XDG_DATA_HOME = {envtmpdir}/share
 
     # This is required to get coverage for Cython
-    py{38,39,310,311,312}-!nocover: BST_CYTHON_TRACE = 1
+    py{39,310,311,312}-!nocover: BST_CYTHON_TRACE = 1
     randomized: PYTEST_ADDOPTS="--random-order-bucket=global"
 
 allowlist_externals =
-    py{38,39,310,311,312}:
+    py{39,310,311,312}:
         mv
         mkdir