Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route policy to wait for K_SINK injection #3532

Open
christophd opened this issue Aug 10, 2022 · 5 comments
Open

Add route policy to wait for K_SINK injection #3532

christophd opened this issue Aug 10, 2022 · 5 comments
Labels
area/knative Related to Knative

Comments

@christophd
Copy link
Contributor

This is related to #3522 where the integration pod fails right after the start because K_SINK has not been injected by Knative sink binding controller before the Camel route starts. So the Pod results in error state recovering once the K_SINK env var has been injected.

We should avoid the failure state by adding a route policy and a dedicated health check when the integration needs a K_SINK so in essence, the route policy would not start the route if the mentioned env var is not set and an health check could make the pod not ready.

@squakez squakez added the area/knative Related to Knative label Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@christophd
Copy link
Contributor Author

Please mark as non stale because this one still is relevant

@squakez
Copy link
Contributor

squakez commented Apr 18, 2024

Is this still relevant today? I wonder if with the recent cleaning on Knative trait, this has cleared as well. Any possible way to double check please?

@christophd
Copy link
Contributor Author

I think this is still a relevant case. I just had the situation yesterday that Knative eventing and serving was not ready on a cluster for some reason and the integration using K_SINK injection just went to error with non-intuitive error msg.

At least we need to review the error propagation in case K_SINK injection is missing for an integration. Maybe we can add a new IntegrationReady condition for that case.

I am planning to work on this soon

@christophd christophd self-assigned this Apr 19, 2024
@squakez squakez added this to the 2.4.0 milestone Apr 19, 2024
@lburgazzoli
Copy link
Contributor

@christophd, I've added a readiness health check in the knative component, see https://github.com/apache/camel/blob/ec871bfddf4f5e88818b6b31f989719a7be52faa/components/camel-knative/camel-knative-component/src/main/java/org/apache/camel/component/knative/KnativeProducer.java#L120-L141

It is not active by default as the producer health check must be explicitly enabled on camel so I'm not sure if it is enough but maybe we can start from that.

@christophd christophd removed their assignment Jun 5, 2024
@squakez squakez modified the milestones: 2.4.0, 2.5.0 Jul 30, 2024
@squakez squakez removed this from the 2.5.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/knative Related to Knative
Projects
None yet
Development

No branches or pull requests

4 participants