Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Allow to set log level of a specific package using logging trait #3974

Open
agiertli opened this issue Jan 12, 2023 · 6 comments
Open
Labels
area/traits good first issue Does not require full understanding of the codebase kind/feature New feature or request status/never-stale

Comments

@agiertli
Copy link

agiertli commented Jan 12, 2023

Currently, we need to set log level of a specific package using property, i.e.:
kamel run -p quarkus.log.category.”org.test”.level=DEBUG

It would be nice if we could utilize logging trait for this in some way. i.e.:

kamel run --trait logging."org.test"=DEBUG

This would allow logging to be configured in a consistent way.

@squakez squakez added kind/feature New feature or request good first issue Does not require full understanding of the codebase area/traits labels Jan 12, 2023
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale due to 90 days of inactivity.
It will be closed if no further activity occurs within 15 days.
If you think that’s incorrect or the issue should never stale, please simply write any comment.
Thanks for your contributions!

@realMartinez
Copy link
Contributor

I can take a look at this

@squakez
Copy link
Contributor

squakez commented Oct 9, 2023

We can mimick route trait configuration where we have:

 -t "route.annotations.'haproxy.router.openshift.io/balance'=true"

and develop something similar with:

 -t "logging.category.'org.test'=DEBUG"

@squakez squakez added this to the 2.2.0 milestone Oct 17, 2023
@squakez squakez modified the milestones: 2.2.0, 2.3.0 Jan 8, 2024
@squakez squakez removed this from the 2.3.0 milestone Apr 2, 2024
@squakez
Copy link
Contributor

squakez commented Apr 18, 2024

@realMartinez @claudio4j what's the status of this? are you going to work on it and include in 2.4 milestone?

@claudio4j
Copy link
Contributor

@realMartinez The previous PR #5279 was declined, since the environment variables were deprecated, but you can use the same code to create the jvm option instead of the environment variable, however to add the new category trait option requires a change in camel-k-runtime project, see GenerateCatalogMojo.java

@realMartinez
Copy link
Contributor

sure I can take a look at this.

@realMartinez realMartinez removed their assignment Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/traits good first issue Does not require full understanding of the codebase kind/feature New feature or request status/never-stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants