Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CELEBORN-1233] Add unit test to verify data correctness #2638

Closed
wants to merge 4 commits into from

Conversation

jiang13021
Copy link
Contributor

What changes were proposed in this pull request?

Add a unit test for #2235

Why are the changes needed?

ditto

Does this PR introduce any user-facing change?

No

How was this patch tested?

org.apache.celeborn.tests.spark.CelebornWorkerRestartSuite

@jiang13021 jiang13021 force-pushed the add_ut_for_CELEBORN-1233 branch from 1c4fee0 to 789f32c Compare July 19, 2024 05:58
@jiang13021
Copy link
Contributor Author

ping @waitinfuture @RexXiong Please take a look. Thanks.

@RexXiong
Copy link
Contributor

ping @waitinfuture @RexXiong Please take a look. Thanks.

see comments at #2609

Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Aug 20, 2024
@jiang13021
Copy link
Contributor Author

ping @waitinfuture @RexXiong Please take a look. Thanks.

see comments at #2609

Hi, we found that without CELEBORN-1233's PR: #2235 , if a file is deleted, the worker won't throw an exception and this could lead to data correctness issues. There is no unit test for CELEBORN-1233, so I have written one. However, it is not a unit test for #2609.

@github-actions github-actions bot removed the stale label Aug 27, 2024
Copy link

This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale label Sep 16, 2024
Copy link

This issue was closed because it has been staled for 10 days with no activity.

@github-actions github-actions bot closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants