improve code coverage

Author: sudo87

server/src/test/java/com/cloud/user/AccountManagerImplTest.java

@@ -23,6 +23,7 @@
 import java.net.UnknownHostException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collections;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -1605,4 +1606,104 @@ public void testcheckCallerApiPermissionsForUserOperationsNotAllowedApis() {
 
         accountManagerImpl.checkCallerApiPermissionsForUserOrAccountOperations(accountMock);
     }
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void testPasswordChangeRequiredWithSamlThrowsException() {
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.SAML2, true
+        );
+    }
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void testPasswordChangeRequiredWithLdapSourceThrows() {
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.LDAP, true);
+    }
+
+    @Test(expected = CloudRuntimeException.class)
+    public void testDomainNotFound() {
+        Mockito.when(_domainMgr.getDomain(1L)).thenReturn(null);
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.UNKNOWN, false);
+    }
+
+    @Test(expected = CloudRuntimeException.class)
+    public void testCreateUserInactiveDomain() {
+        Mockito.when(domainVoMock.getState()).thenReturn(Domain.State.Inactive);
+        Mockito.when(_domainMgr.getDomain(Mockito.anyLong())).thenReturn(domainVoMock);
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.NATIVE, false);
+    }
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void testCreateUserCheckAccess() {
+        Mockito.when(domainVoMock.getState()).thenReturn(Domain.State.Active);
+        Mockito.when(_domainMgr.getDomain(Mockito.anyLong())).thenReturn(domainVoMock);
+        Mockito.doNothing().when(accountManagerImpl).checkAccess(Mockito.any(Account.class), Mockito.any(Domain.class));
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.NATIVE, false);
+    }
+
+    @Test(expected = InvalidParameterValueException.class)
+    public void testCreateUserMissingOrProjectAccount() {
+        Mockito.when(domainVoMock.getState()).thenReturn(Domain.State.Active);
+        Mockito.when(_accountDao.findEnabledAccount(Mockito.anyString(), Mockito.anyLong())).thenReturn(accountMock);
+        Mockito.when(accountMock.getType()).thenReturn(Account.Type.PROJECT);
+        Mockito.when(_domainMgr.getDomain(Mockito.anyLong())).thenReturn(domainVoMock);
+        Mockito.doNothing().when(accountManagerImpl).checkAccess(Mockito.any(Account.class), Mockito.any(Domain.class));
+        accountManagerImpl.createUser(
+                "user", "pass", "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.NATIVE, false);
+    }
+
+    @Test
+    public void testCreateUserSuccess() {
+        Account rootAdminAccount = Mockito.mock(Account.class);
+        Mockito.when(rootAdminAccount.getId()).thenReturn(1L);
+        Mockito.when(accountManagerImpl.isRootAdmin(1L)).thenReturn(true);
+        User callingUser = Mockito.mock(User.class);
+        CallContext.register(callingUser, rootAdminAccount);
+
+        String newPassword = "newPassword";
+        configureUserMockAuthenticators(newPassword);
+        Mockito.doNothing().when(accountManagerImpl).checkAccess(any(Account.class), any(Domain.class));
+        Mockito.doReturn(accountMock).when(accountManagerImpl).getAccount(Mockito.anyLong());
+        Mockito.doNothing().when(passwordPolicyMock).verifyIfPasswordCompliesWithPasswordPolicies(Mockito.anyString(), Mockito.anyString(), Mockito.anyLong());
+        Mockito.when(_domainMgr.getDomain(Mockito.anyLong())).thenReturn(domainVoMock);
+        Mockito.when(domainVoMock.getState()).thenReturn(Domain.State.Active);
+
+        Mockito.when(_accountDao.findEnabledAccount(Mockito.anyString(), Mockito.anyLong())).thenReturn(accountMock);
+        Mockito.when(accountMock.getId()).thenReturn(10L);
+        Mockito.when(accountMock.getType()).thenReturn(Account.Type.NORMAL);
+
+        Mockito.when(userAccountDaoMock.validateUsernameInDomain(Mockito.anyString(), Mockito.anyLong())).thenReturn(true);
+        Mockito.when(userDaoMock.findUsersByName(Mockito.anyString())).thenReturn(Collections.emptyList());
+        UserVO createdUser = new UserVO();
+        String userMockUUID = "userMockUUID";
+        createdUser.setUuid(userMockUUID);
+        Mockito.when(userDaoMock.persist(Mockito.any(UserVO.class))).thenReturn(createdUser);
+        UserVO userResultVO = accountManagerImpl.createUser(
+                "user", newPassword, "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.NATIVE, false
+        );
+        Assert.assertNotNull(userResultVO);
+        UserVO userResultPasswordChangeVO = accountManagerImpl.createUser(
+                "user", newPassword, "fn", "ln", "[email protected]",
+                "UTC", "acct", 1L, null,
+                User.Source.NATIVE, true
+        );
+        Assert.assertNotNull(userResultVO);
+    }
 }