Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove offering button should not be shown if the action is not allowed #9393

Closed
DaanHoogland opened this issue Jul 15, 2024 · 2 comments
Closed

Comments

@DaanHoogland
Copy link
Contributor

ISSUE TYPE
  • Improvement Request
COMPONENT NAME

CLOUDSTACK VERSION
4.19
CONFIGURATION
OS / ENVIRONMENT
SUMMARY

as described in #9391 (comment) remove backup offering should only be shown if remove backup offering is allowed. (i.e. not for dummy offering or any other that might disallow it.)

see also
image

STEPS TO REPRODUCE

EXPECTED RESULTS

ACTUAL RESULTS

@abh1sar
Copy link
Collaborator

abh1sar commented Aug 21, 2024

@DaanHoogland in the given example in #9391 (comment), the backup offering could be deleted using the 'force' option.
So, I think the remove offering button should still be shown. The error only gives the warning that using the 'force' option will delete all the backups.
Please let me know your thoughts

@abh1sar abh1sar moved this from Todo to Discuss in Apache CloudStack BugFest - Issues Aug 21, 2024
@DaanHoogland
Copy link
Contributor Author

@DaanHoogland in the given example in #9391 (comment), the backup offering could be deleted using the 'force' option. So, I think the remove offering button should still be shown. The error only gives the warning that using the 'force' option will delete all the backups. Please let me know your thoughts

So you are saying we should not implement this at all, right @abh1sar ? If the functionality is consistant, I am fine with keeping it, but it seemed odd to me at the time (close at will)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants