Fix CKS cluster creation not honoring the CKS ISO arch by nvazquez · Pull Request #11902 · apache/cloudstack

nvazquez · 2025-10-24T02:20:51Z

Description

This PR fixes the CKS cluster creation logic to honor the CKS ISO arch type.

Fixes: #11734

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Tested on multi-arch zone

Registered CKS ISOs for x86_64 and arm64 with their corresponding arch value set
Set system.vm.preferred.architecture = aarch64
Create CKS cluster selecting the CKS ISO for arm64 -> Observe the CKS nodes and VR are deployed on arm64 hosts.

How did you try to break this feature and the system with this change?

nvazquez · 2025-10-24T02:22:09Z

@blueorangutan package

blueorangutan · 2025-10-24T02:24:03Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-10-24T02:29:53Z

Codecov Report

❌ Patch coverage is 4.34783% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (b1851ba) to head (1088f39).
⚠️ Report is 14 commits behind head on main.

Files with missing lines	Patch %	Lines
...KubernetesClusterResourceModifierActionWorker.java	0.00%	12 Missing ⚠️
...dstack/api/response/KubernetesClusterResponse.java	0.00%	6 Missing ⚠️
...er/actionworkers/KubernetesClusterScaleWorker.java	0.00%	2 Missing ⚠️
...bernetes/cluster/KubernetesClusterManagerImpl.java	50.00%	1 Missing ⚠️
...er/actionworkers/KubernetesClusterStartWorker.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11902   +/-   ##
=========================================
  Coverage     17.56%   17.56%           
  Complexity    15533    15533           
=========================================
  Files          5909     5909           
  Lines        529013   529021    +8     
  Branches      64605    64607    +2     
=========================================
+ Hits          92912    92916    +4     
- Misses       425652   425659    +7     
+ Partials      10449    10446    -3

Flag	Coverage Δ
uitests	`3.58% <ø> (ø)`
unittests	`18.63% <4.34%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-10-24T03:53:34Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15537

harikrishna-patnala

code LGTM

kiranchavala

@nvazquez

Hitting the same issue again , the cks cluster selects the systemvmtemplate for arm for deployment even if the preffered architecture is x86_64

@harikrishna-patnala is working on a fix

harikrishna-patnala · 2025-10-24T07:27:13Z

@nvazquez I've pushed a fix to compare the preferred arch type with template arch type, because names are different than types here

https://github.com/shapeblue/cloudstack/blob/12c077d7045174d51374fce2118422d1dcf06657/api/src/main/java/com/cloud/cpu/CPU.java#L22-L26

harikrishna-patnala · 2025-10-24T07:42:32Z

@blueorangutan package

blueorangutan · 2025-10-24T07:44:03Z

@harikrishna-patnala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-24T08:55:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15544

kiranchavala

LGTM

Able to deploy cks cluster on amd , arm clusters architecture

nvazquez · 2025-10-24T10:43:46Z

@blueorangutan package

blueorangutan · 2025-10-24T10:46:04Z

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

harikrishna-patnala · 2025-10-24T10:51:23Z

Thanks @nvazquez tested the last commit locally, it worked fine.

blueorangutan · 2025-10-24T12:17:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15547

nvazquez · 2025-10-24T16:20:21Z

@blueorangutan test

blueorangutan · 2025-10-24T16:22:04Z

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

Pearl1594

code lgtm

blueorangutan · 2025-10-25T13:41:34Z

[SF] Trillian test result (tid-14723)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 72213 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11902-t14723-kvm-ol8.zip
Smoke tests completed. 143 look OK, 1 have errors, 5 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_vpn_usage	`Error`	1.41	test_usage.py
all_test_human_readable_logs	`Skipped`	---	test_human_readable_logs.py
all_test_image_store_object_migration	`Skipped`	---	test_image_store_object_migration.py
all_test_import_unmanage_volumes	`Skipped`	---	test_import_unmanage_volumes.py
all_test_internal_lb	`Skipped`	---	test_internal_lb.py
all_test_ipv4_routing	`Skipped`	---	test_ipv4_routing.py

* Fix CKS cluster creation not honouring the CKS ISO arch * Fix arch type reference to choose right template * Include template name on the CKS clusters response --------- Co-authored-by: Harikrishna Patnala <[email protected]>

Fix CKS cluster creation not honouring the CKS ISO arch

671c672

nvazquez added this to the 4.22.0 milestone Oct 24, 2025

nvazquez requested review from DaanHoogland, Pearl1594, harikrishna-patnala, kiranchavala, shwstppr, vishesh92 and yadvr October 24, 2025 02:20

nvazquez added type:bug component:cks labels Oct 24, 2025

boring-cyborg bot added the component:kubernetes label Oct 24, 2025

harikrishna-patnala approved these changes Oct 24, 2025

View reviewed changes

Fix arch type reference to choose right template

2540497

kiranchavala reviewed Oct 24, 2025

View reviewed changes

kiranchavala approved these changes Oct 24, 2025

View reviewed changes

Include template name on the CKS clusters response

1088f39

Pearl1594 approved these changes Oct 24, 2025

View reviewed changes

harikrishna-patnala merged commit 2dbc86a into apache:main Oct 27, 2025
58 of 62 checks passed

harikrishna-patnala deleted the 422-fix-cks-cluster-arch branch October 27, 2025 05:28

harikrishna-patnala added this to Apache CloudStack 4.22.0 Oct 27, 2025

Conversation

nvazquez commented Oct 24, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

nvazquez commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

codecov bot commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

harikrishna-patnala commented Oct 24, 2025

Uh oh!

harikrishna-patnala commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

nvazquez commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

harikrishna-patnala commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

nvazquez commented Oct 24, 2025

Uh oh!

blueorangutan commented Oct 24, 2025

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

blueorangutan commented Oct 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Oct 24, 2025 •

edited

Loading