Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolving the dependency io.github.g00fy2:versioncompare:1.4.1@jar mentioned in cordova.gradle #1759

Open
burhanuddin-taha opened this issue Jan 14, 2025 · 0 comments
Labels
Milestone

Comments

@burhanuddin-taha
Copy link

Feature Request

Motivation Behind Feature

Currently all the repo can be overridden by using extra.gradle. as changes done under feat: add custom repositories support #867

But still cordovaLib is using cordova.gradle have block
repositories {
google()
mavenCentral()
}
which means dependency io.github.g00fy2:versioncompare:1.4.1@jar could not be resolved using any internal artifact repository server like jfrog artifactory or nexus,

Feature Description

Extend the existing feature provided under feat: add custom repositories support #867 to cordova.gradle, means instead hardcoded repositories
repositories {
google()
mavenCentral()
}

Read the repos from the already placed repositories.gradle,
which is already in place for androidLib/build.gradle file. Same should be go in to the cordova.gradle. here is the example

buildscript {
apply from: 'repositories.gradle'

repositories repos

dependencies {
    classpath 'io.github.g00fy2:versioncompare:1.4.1@jar'
}

}

Alternatives or Workarounds

Currently only workaround is to write custom hook to replace the repos mentioned in the cordova.gradle after platform add.

@breautek breautek added the bug label Jan 14, 2025
@breautek breautek added this to the 13.0.1 milestone Jan 14, 2025
@breautek breautek modified the milestones: 13.0.1, 14.0.0 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants