Skip to content

Commit 66008db

Browse files
committed
fix unit tests
1 parent fad2b62 commit 66008db

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

spark/src/test/scala/org/apache/comet/exec/CometAggregateSuite.scala

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,8 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
409409
(0 until 100).map(i => (i, (i % 10).toString)),
410410
"tbl",
411411
dictionaryEnabled) {
412-
val n = if (nativeShuffleEnabled) 2 else 1
412+
val n =
413+
if (nativeShuffleEnabled || CometConf.COMET_PREFER_TO_ARROW_ENABLED.get()) 2 else 1
413414
checkSparkAnswerAndNumOfAggregates("SELECT _2, SUM(_1) FROM tbl GROUP BY _2", n)
414415
checkSparkAnswerAndNumOfAggregates("SELECT _2, COUNT(_1) FROM tbl GROUP BY _2", n)
415416
checkSparkAnswerAndNumOfAggregates("SELECT _2, MIN(_1) FROM tbl GROUP BY _2", n)
@@ -592,7 +593,9 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
592593
val path = new Path(dir.toURI.toString, "test")
593594
makeParquetFile(path, 1000, 20, dictionaryEnabled)
594595
withParquetTable(path.toUri.toString, "tbl") {
595-
val expectedNumOfCometAggregates = if (nativeShuffleEnabled) 2 else 1
596+
val expectedNumOfCometAggregates =
597+
if (nativeShuffleEnabled || CometConf.COMET_PREFER_TO_ARROW_ENABLED.get()) 2
598+
else 1
596599

597600
checkSparkAnswerAndNumOfAggregates(
598601
"SELECT _g2, SUM(_7) FROM tbl GROUP BY _g2",
@@ -734,7 +737,11 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
734737
sql("CREATE TABLE t(v VARCHAR(3), i INT) USING PARQUET")
735738
sql("INSERT INTO t VALUES ('c', 1)")
736739
withSQLConf(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "false") {
737-
checkSparkAnswerAndNumOfAggregates("SELECT v, sum(i) FROM t GROUP BY v ORDER BY v", 1)
740+
val expectedNumOfCometAggregates =
741+
if (CometConf.COMET_PREFER_TO_ARROW_ENABLED.get()) 2 else 1
742+
checkSparkAnswerAndNumOfAggregates(
743+
"SELECT v, sum(i) FROM t GROUP BY v ORDER BY v",
744+
expectedNumOfCometAggregates)
738745
}
739746
}
740747
}
@@ -1058,7 +1065,11 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
10581065
"tbl",
10591066
dictionaryEnabled) {
10601067
withSQLConf(CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "false") {
1061-
checkSparkAnswerAndNumOfAggregates("SELECT _2 , AVG(_1) FROM tbl GROUP BY _2", 1)
1068+
val expectedNumOfCometAggregates =
1069+
if (CometConf.COMET_PREFER_TO_ARROW_ENABLED.get()) 2 else 1
1070+
checkSparkAnswerAndNumOfAggregates(
1071+
"SELECT _2 , AVG(_1) FROM tbl GROUP BY _2",
1072+
expectedNumOfCometAggregates)
10621073
}
10631074
}
10641075
}
@@ -1095,7 +1106,9 @@ class CometAggregateSuite extends CometTestBase with AdaptiveSparkPlanHelper {
10951106
val path = new Path(dir.toURI.toString, "test")
10961107
makeParquetFile(path, 1000, 20, dictionaryEnabled)
10971108
withParquetTable(path.toUri.toString, "tbl") {
1098-
val expectedNumOfCometAggregates = if (nativeShuffleEnabled) 2 else 1
1109+
val expectedNumOfCometAggregates =
1110+
if (nativeShuffleEnabled || CometConf.COMET_PREFER_TO_ARROW_ENABLED.get()) 2
1111+
else 1
10991112

11001113
checkSparkAnswerAndNumOfAggregates(
11011114
"SELECT _g2, AVG(_7) FROM tbl GROUP BY _g2",

0 commit comments

Comments
 (0)