Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support ANSI mode for round #466

Open
andygrove opened this issue May 23, 2024 · 3 comments · May be fixed by #989
Open

feat: Support ANSI mode for round #466

andygrove opened this issue May 23, 2024 · 3 comments · May be fixed by #989
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@andygrove
Copy link
Member

What is the problem the feature request solves?

Comet does not support ANSI mode for round.

Create test data

val df = Seq(Int.MaxValue, Int.MinValue).toDF("a")
df.write.parquet("/tmp/int.parquet")
spark.read.parquet("/tmp/int.parquet").createTempView("t")

Test with ANSI enabled

Comet does not throw an exception but Spark does.

scala> spark.conf.set("spark.comet.ansi.enabled", true)

scala> spark.conf.set("spark.sql.ansi.enabled", true)

scala> spark.conf.set("spark.comet.enabled", true)

scala> spark.sql("select a, round(a,-1) from t").show
24/05/23 14:10:30 WARN CometSparkSessionExtensions$CometExecRule: Using Comet's experimental support for ANSI mode.
24/05/23 14:10:30 WARN CometSparkSessionExtensions$CometExecRule: Comet cannot execute some parts of this plan natively because CollectLimit is not supported
+-----------+------------+
|          a|round(a, -1)|
+-----------+------------+
| 2147483647| -2147483646|
|-2147483648|  2147483646|
+-----------+------------+


scala> spark.conf.set("spark.comet.enabled", false)

scala> spark.sql("select a, round(a,-1) from t").show
24/05/23 14:10:37 WARN CometSparkSessionExtensions$CometExecRule: Using Comet's experimental support for ANSI mode.
24/05/23 14:10:38 ERROR Executor: Exception in task 0.0 in stage 15.0 (TID 15)
org.apache.spark.SparkArithmeticException: [ARITHMETIC_OVERFLOW] Overflow. If necessary set "spark.sql.ansi.enabled" to "false" to bypass this error.
== SQL(line 1, position 11) ==
select a, round(a,-1) from t
          ^^^^^^^^^^^

Describe the potential solution

No response

Additional context

No response

@andygrove andygrove added enhancement New feature or request good first issue Good for newcomers labels May 23, 2024
@vidyasankarv
Copy link
Contributor

I will work on this one

@andygrove andygrove added the help wanted Extra attention is needed label Jun 6, 2024
@vidyasankarv
Copy link
Contributor

vidyasankarv commented Jun 19, 2024

Had to take a temporary break, Will resume this if no one else is already looking into this. Thank you

@raulcd raulcd linked a pull request Oct 1, 2024 that will close this issue
@raulcd
Copy link
Member

raulcd commented Oct 1, 2024

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants