Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GroupOrderingPartial performance #14565

Open
ctsk opened this issue Feb 9, 2025 · 1 comment · May be fixed by #14566
Open

Improve GroupOrderingPartial performance #14565

ctsk opened this issue Feb 9, 2025 · 1 comment · May be fixed by #14566
Assignees
@ctsk

Comments

@ctsk
Copy link

ctsk commented Feb 9, 2025

The current implementation of GroupOrderingPartial updates its internal state by converting any incoming batch into the row format, and then traversing that format to determine if the sort key changed.

I believe that the same can be computed (more effiently?) without such a conversion by using arrow_ord::partition::partition.
@ctsk
Copy link
Author

ctsk commented Feb 9, 2025

take

@ctsk ctsk linked a pull request Feb 9, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctsk ctsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Drop RowConverter from GroupOrderingPartial ctsk/datafusion
1 participant
@ctsk