Skip to content

Commit

Permalink
[Fix](auto-pick)Allow doris-robot to trigger the workflow (#43166)
Browse files Browse the repository at this point in the history
### What problem does this PR solve?
 https://github.com/orgs/community/discussions/55906 

Due to security restrictions, the GitHub Actions bot cannot trigger
workflows directly. Instead, we use doris-robot to initiate other CI
runs. Only automatically generated PRs will prompt doris-robot to
comment, and we verify the author and content to determine whether a
workflow should be triggered. This approach does not affect the original
CI process; it simply adds an additional trigger condition.

### Check List (For Committer)

- Test <!-- At least one of them must be included. -->

    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [x] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No colde files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:

    - [x] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?

    - [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

- Release note

    <!-- bugfix, feat, behavior changed need a release note -->
    <!-- Add one line release note for this PR. -->
    None

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
  • Loading branch information
CalvinKirs authored Nov 4, 2024
1 parent dbd490d commit f04f044
Show file tree
Hide file tree
Showing 5 changed files with 50 additions and 3 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/build-extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ name: Build Extensions

on:
pull_request:

workflow_dispatch:
issue_comment:
types: [ created ]
concurrency:
group: ${{ github.ref }} (Build Extensions)
cancel-in-progress: true
Expand All @@ -29,6 +31,12 @@ jobs:
changes:
name: Detect Changes
runs-on: ubuntu-latest
if: |
(github.event_name == 'pull_request') ||
(github.event_name == 'issue_comment' &&
github.event.comment.body == 'run buildall' &&
github.actor == 'doris-robot' &&
github.event.issue.user.login == 'github-actions[bot]')
outputs:
broker_changes: ${{ steps.filter.outputs.broker_changes }}
docs_changes: ${{ steps.filter.outputs.docs_changes }}
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/build-thirdparty.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ name: Build Third Party Libraries

on:
pull_request:
workflow_dispatch:
issue_comment:
types: [ created ]

concurrency:
group: ${{ github.ref }} (Build Third Party Libraries)
Expand All @@ -28,6 +31,12 @@ jobs:
changes:
name: Detect Changes
runs-on: ubuntu-latest
if: |
(github.event_name == 'pull_request') ||
(github.event_name == 'issue_comment' &&
github.event.comment.body == 'run buildall' &&
github.actor == 'doris-robot' &&
github.event.issue.user.login == 'github-actions[bot]')
outputs:
thirdparty_changes: ${{ steps.filter.outputs.thirdparty_changes }}
steps:
Expand Down
9 changes: 9 additions & 0 deletions .github/workflows/checkstyle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,20 @@ name: FE Code Style Checker

on:
pull_request:
workflow_dispatch:
issue_comment:
types: [ created ]

jobs:
java-checkstyle:
name: "CheckStyle"
runs-on: ubuntu-latest
if: |
(github.event_name == 'pull_request') ||
(github.event_name == 'issue_comment' &&
github.event.comment.body == 'run buildall' &&
github.actor == 'doris-robot' &&
github.event.issue.user.login == 'github-actions[bot]')
steps:
- name: Checkout
uses: actions/checkout@v3
Expand Down
14 changes: 12 additions & 2 deletions .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,22 @@
---
name: Code Formatter

on: [push, pull_request_target]

on:
pull_request:
pull_request_target:
workflow_dispatch:
issue_comment:
types: [ created ]
jobs:
clang-format:
name: "Clang Formatter"
runs-on: ubuntu-latest
if: |
(github.event_name == 'pull_request') || (github.event_name == 'pull_request_target') ||
(github.event_name == 'issue_comment' &&
github.event.comment.body == 'run buildall' &&
github.actor == 'doris-robot' &&
github.event.issue.user.login == 'github-actions[bot]')
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
if: ${{ github.event_name != 'pull_request_target' }}
Expand Down
11 changes: 11 additions & 0 deletions .github/workflows/license-eyes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,21 @@ on:
push:
branches:
- master
workflow_dispatch:
issue_comment:
types: [ created ]

jobs:
license-check:
name: "License Check"
runs-on: ubuntu-latest
if: |
(github.event_name == 'pull_request_target') ||
(github.event_name == 'push' && github.ref == 'refs/heads/master') ||
(github.event_name == 'issue_comment' &&
github.event.comment.body == 'run buildall' &&
github.actor == 'doris-robot' &&
github.event.issue.user.login == 'github-actions[bot]')
steps:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
if: ${{ github.event_name != 'pull_request_target' }}
Expand Down

0 comments on commit f04f044

Please sign in to comment.