[fix](prepared statement) fix protocol with TIME datatype #47389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
eldenmoon
force-pushed
the
fix-prep-timetype
branch
from
7f8eb6e to
4934b00
Compare
|
run buildall |
TPC-H: Total hot run time: 32311 ms |
TPC-DS: Total hot run time: 184725 ms |
ClickBench: Total hot run time: 31.09 s |
|
TeamCity be ut coverage result: |
csun5285
reviewed
Feb 5, 2025
| MysqlRowBuffer<true> buffer; | ||
|
|
||
| // case1 : all 0, should only send 1 byte | ||
| buffer.push_timev2(0.0, 6); |
There was a problem hiding this comment.
check the contents of a buffer
eldenmoon
force-pushed
the
fix-prep-timetype
branch
from
4934b00 to
25c138d
Compare
eldenmoon
force-pushed
the
fix-prep-timetype
branch
from
25c138d to
cdd68be
Compare
|
run buildall |
TPC-H: Total hot run time: 32141 ms |
TPC-DS: Total hot run time: 190973 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.12 s |
xiaokang
changed the title
HappenLee
reviewed
Feb 6, 2025
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
This pull request adds functionality to encode time values into MySQL binary protocol format with microsecond precision and includes corresponding test cases. The changes primarily involve adding a new function for encoding time and updating the `push_time` and `push_timev2` methods in the `MysqlRowBuffer` class to use this new function. ### Encoding time into MySQL binary protocol format: * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbR364-R433): Added the `encode_binary_timev2` function to encode time into MySQL binary protocol format with support for microsecond precision. The function handles time values within the range of '-838:59:59' to '838:59:59' and adjusts the precision based on the provided scale. ### Updates to `MysqlRowBuffer` class: * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbR364-R433): Updated the `push_time` method to throw an exception for unsupported time types in binary protocol. * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbL382-R451): Modified the `push_timev2` method to use the new `encode_binary_timev2` function, adjusting the buffer size and appending the encoded time. ### Test cases: * [`be/test/util/mysql_row_buffer_test.cpp`](diffhunk://#diff-1feab58caea3546e0e6fda52bff2fbd5f60f7cafcef8f891be83b0a2f74a93ebR118-R133): Added a new test case `TestBinaryTimeCompressedEncoding` to verify the correct encoding of time values in various scenarios, including zero time, time without microseconds, time with microseconds, and negative time values.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
This pull request adds functionality to encode time values into MySQL binary protocol format with microsecond precision and includes corresponding test cases. The changes primarily involve adding a new function for encoding time and updating the `push_time` and `push_timev2` methods in the `MysqlRowBuffer` class to use this new function. ### Encoding time into MySQL binary protocol format: * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbR364-R433): Added the `encode_binary_timev2` function to encode time into MySQL binary protocol format with support for microsecond precision. The function handles time values within the range of '-838:59:59' to '838:59:59' and adjusts the precision based on the provided scale. ### Updates to `MysqlRowBuffer` class: * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbR364-R433): Updated the `push_time` method to throw an exception for unsupported time types in binary protocol. * [`be/src/util/mysql_row_buffer.cpp`](diffhunk://#diff-181b7a490933fd9d3f8a00c97852d8fa17ab34694b1683ffd762e0f595a7c4fbL382-R451): Modified the `push_timev2` method to use the new `encode_binary_timev2` function, adjusting the buffer size and appending the encoded time. ### Test cases: * [`be/test/util/mysql_row_buffer_test.cpp`](diffhunk://#diff-1feab58caea3546e0e6fda52bff2fbd5f60f7cafcef8f891be83b0a2f74a93ebR118-R133): Added a new test case `TestBinaryTimeCompressedEncoding` to verify the correct encoding of time values in various scenarios, including zero time, time without microseconds, time with microseconds, and negative time values.
yiguolei
pushed a commit
that referenced
this pull request
Feb 8, 2025
…47389 (#47543) Cherry-picked from #47389 Co-authored-by: lihangyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request adds functionality to encode time values into MySQL binary protocol format with microsecond precision and includes corresponding test cases. The changes primarily involve adding a new function for encoding time and updating the
push_timeandpush_timev2methods in theMysqlRowBufferclass to use this new function.Encoding time into MySQL binary protocol format:
be/src/util/mysql_row_buffer.cpp: Added theencode_binary_timev2function to encode time into MySQL binary protocol format with support for microsecond precision. The function handles time values within the range of '-838:59:59' to '838:59:59' and adjusts the precision based on the provided scale.Updates to
MysqlRowBufferclass:be/src/util/mysql_row_buffer.cpp: Updated thepush_timemethod to throw an exception for unsupported time types in binary protocol.be/src/util/mysql_row_buffer.cpp: Modified thepush_timev2method to use the newencode_binary_timev2function, adjusting the buffer size and appending the encoded time.Test cases:
be/test/util/mysql_row_buffer_test.cpp: Added a new test caseTestBinaryTimeCompressedEncodingto verify the correct encoding of time values in various scenarios, including zero time, time without microseconds, time with microseconds, and negative time values.Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)