-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](cloud-mow)Fix not release delete bitmap lock when checking txn state is visible #47580
Conversation
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
run buildall |
TPC-H: Total hot run time: 31570 ms
|
TPC-DS: Total hot run time: 189462 ms
|
ClickBench: Total hot run time: 30.54 s
|
fe/fe-core/src/main/java/org/apache/doris/cloud/transaction/CloudGlobalTransactionMgr.java
Show resolved
Hide resolved
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 31696 ms
|
TPC-DS: Total hot run time: 190416 ms
|
ClickBench: Total hot run time: 30.49 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Fe should check txn state before calculate delete bitmap, if txn state is visible, just retrurn ok to be, no need to recalculate delete bitmap again.This check operation should do before get delete bitmap lock, otherwise delete bitmap lock will not relase until time out.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)