Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](regression) topn-filter unstable case #47797

Merged
merged 2 commits into from
Feb 17, 2025
Merged

[fix](regression) topn-filter unstable case #47797

merged 2 commits into from
Feb 17, 2025

Conversation

englefly
Copy link
Contributor

What problem does this PR solve?

regression-test/suites/query_p0/test_array_orderby_limit.groovy is unstable
when case failed, plan shows that the table row count is 0.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@englefly
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31370 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c5d6ca528eac384df4e36907c21ceedefb83aadc, data reload: false

------ Round 1 ----------------------------------
q1	17586	5229	5067	5067
q2	2052	309	168	168
q3	10389	1334	703	703
q4	10219	1007	535	535
q5	7522	2390	2332	2332
q6	191	167	133	133
q7	912	743	595	595
q8	9301	1266	1110	1110
q9	4916	4710	4572	4572
q10	6823	2317	1873	1873
q11	470	271	271	271
q12	348	362	220	220
q13	17755	3651	3084	3084
q14	228	226	209	209
q15	527	469	477	469
q16	619	600	569	569
q17	551	854	337	337
q18	6635	6272	6208	6208
q19	1201	929	528	528
q20	308	335	192	192
q21	2757	2116	1881	1881
q22	364	328	314	314
Total cold run time: 101674 ms
Total hot run time: 31370 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5129	5150	5123	5123
q2	240	322	245	245
q3	2183	2668	2325	2325
q4	1427	1791	1335	1335
q5	4253	4135	4199	4135
q6	202	163	127	127
q7	1867	1820	1648	1648
q8	2585	2584	2524	2524
q9	7240	7023	7044	7023
q10	2992	3188	2788	2788
q11	589	517	486	486
q12	708	806	638	638
q13	3501	3950	3315	3315
q14	291	294	271	271
q15	515	469	471	469
q16	652	674	633	633
q17	1124	1589	1351	1351
q18	7548	7478	7364	7364
q19	770	863	863	863
q20	2008	2035	1866	1866
q21	5401	4915	4881	4881
q22	644	585	548	548
Total cold run time: 51869 ms
Total hot run time: 49958 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 182848 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c5d6ca528eac384df4e36907c21ceedefb83aadc, data reload: false

query1	964	381	374	374
query2	6513	1851	1788	1788
query3	6862	206	205	205
query4	26510	23808	23128	23128
query5	4328	630	477	477
query6	285	202	178	178
query7	4595	490	308	308
query8	279	233	215	215
query9	8600	2488	2486	2486
query10	452	307	241	241
query11	15933	15102	14975	14975
query12	148	105	102	102
query13	1652	525	394	394
query14	9697	6346	6206	6206
query15	220	186	180	180
query16	7157	651	481	481
query17	1204	723	558	558
query18	1963	408	294	294
query19	193	188	162	162
query20	120	120	115	115
query21	210	123	103	103
query22	4062	4196	4047	4047
query23	33753	33000	32969	32969
query24	7699	2376	2358	2358
query25	544	430	375	375
query26	1248	259	153	153
query27	2130	485	323	323
query28	3938	2376	2345	2345
query29	750	535	432	432
query30	227	182	154	154
query31	923	823	846	823
query32	71	65	61	61
query33	558	363	320	320
query34	791	844	487	487
query35	783	793	746	746
query36	953	976	890	890
query37	125	97	78	78
query38	4212	4257	4067	4067
query39	1446	1371	1399	1371
query40	215	114	103	103
query41	56	52	54	52
query42	120	102	103	102
query43	498	502	491	491
query44	1268	795	783	783
query45	172	169	161	161
query46	848	1019	639	639
query47	1728	1781	1712	1712
query48	376	391	294	294
query49	770	501	422	422
query50	692	718	399	399
query51	4178	4218	4073	4073
query52	103	114	93	93
query53	222	256	182	182
query54	494	494	418	418
query55	79	80	79	79
query56	268	260	260	260
query57	1146	1156	1062	1062
query58	241	241	254	241
query59	2583	2752	2760	2752
query60	266	260	254	254
query61	119	115	137	115
query62	788	729	686	686
query63	227	184	187	184
query64	4414	1013	648	648
query65	3269	3122	3126	3122
query66	1133	404	305	305
query67	15545	15347	15339	15339
query68	2866	791	523	523
query69	478	297	293	293
query70	1241	1124	1134	1124
query71	364	287	264	264
query72	6050	3451	3668	3451
query73	637	736	349	349
query74	8957	9023	8747	8747
query75	3134	3161	2653	2653
query76	2953	1169	722	722
query77	465	379	279	279
query78	9887	10106	9311	9311
query79	977	867	571	571
query80	969	530	442	442
query81	531	274	246	246
query82	251	155	118	118
query83	185	174	157	157
query84	301	91	79	79
query85	755	340	301	301
query86	344	301	295	295
query87	4432	4567	4547	4547
query88	2849	2209	2170	2170
query89	387	321	288	288
query90	1772	188	192	188
query91	140	138	109	109
query92	65	58	57	57
query93	1059	981	576	576
query94	672	402	303	303
query95	351	256	256	256
query96	473	545	271	271
query97	2749	2860	2705	2705
query98	220	207	201	201
query99	1293	1430	1312	1312
Total cold run time: 261723 ms
Total hot run time: 182848 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c5d6ca528eac384df4e36907c21ceedefb83aadc, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.03
query3	0.24	0.06	0.07
query4	1.62	0.10	0.10
query5	0.42	0.42	0.41
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.59	0.52	0.52
query10	0.59	0.58	0.58
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.62	0.59	0.61
query14	2.80	2.70	2.68
query15	0.90	0.85	0.86
query16	0.39	0.38	0.37
query17	1.03	1.03	1.03
query18	0.22	0.19	0.20
query19	1.94	1.83	2.02
query20	0.01	0.02	0.01
query21	15.35	0.90	0.55
query22	0.75	1.22	0.65
query23	14.93	1.40	0.65
query24	6.93	2.21	0.97
query25	0.51	0.15	0.07
query26	0.53	0.17	0.15
query27	0.05	0.05	0.05
query28	9.55	0.80	0.44
query29	12.58	3.95	3.31
query30	0.25	0.09	0.06
query31	2.81	0.57	0.38
query32	3.22	0.55	0.47
query33	3.07	3.14	3.03
query34	15.93	5.10	4.48
query35	4.54	4.49	4.52
query36	0.66	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.13
query41	0.09	0.02	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 105.2 s
Total hot run time: 30.75 s

@englefly
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31612 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bd8169b06c7c5d626cc62897a7209a64cc690d4a, data reload: false

------ Round 1 ----------------------------------
q1	17670	5212	5090	5090
q2	2054	295	180	180
q3	10516	1324	692	692
q4	10305	1002	543	543
q5	8500	2454	2321	2321
q6	200	165	130	130
q7	889	752	587	587
q8	9309	1301	1086	1086
q9	5462	4883	4761	4761
q10	6840	2322	1889	1889
q11	487	278	261	261
q12	352	346	220	220
q13	17763	3692	3077	3077
q14	219	222	206	206
q15	498	478	449	449
q16	633	604	584	584
q17	590	859	347	347
q18	6822	6276	6196	6196
q19	1325	935	545	545
q20	313	330	189	189
q21	2924	2161	1958	1958
q22	379	328	301	301
Total cold run time: 104050 ms
Total hot run time: 31612 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5168	5114	5170	5114
q2	240	328	230	230
q3	2127	2669	2267	2267
q4	1452	1811	1354	1354
q5	4227	4132	4142	4132
q6	204	161	125	125
q7	1854	1837	1820	1820
q8	2572	2667	2568	2568
q9	7196	7012	7158	7012
q10	2958	3170	2765	2765
q11	573	508	487	487
q12	731	785	616	616
q13	3458	3917	3237	3237
q14	273	302	293	293
q15	507	479	477	477
q16	656	655	643	643
q17	1106	1554	1355	1355
q18	7552	7263	7235	7235
q19	811	841	932	841
q20	1960	2002	1902	1902
q21	5440	4881	4833	4833
q22	636	609	539	539
Total cold run time: 51701 ms
Total hot run time: 49845 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184046 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit bd8169b06c7c5d626cc62897a7209a64cc690d4a, data reload: false

query1	970	385	373	373
query2	6522	1849	1824	1824
query3	6814	208	206	206
query4	26171	23719	23497	23497
query5	4333	643	508	508
query6	310	193	184	184
query7	4608	521	321	321
query8	299	246	229	229
query9	8602	2492	2488	2488
query10	469	309	249	249
query11	15768	15249	15088	15088
query12	159	108	102	102
query13	1654	504	389	389
query14	9332	6117	6027	6027
query15	211	193	174	174
query16	7157	622	446	446
query17	1191	709	571	571
query18	1936	397	319	319
query19	200	192	155	155
query20	121	121	116	116
query21	210	123	104	104
query22	4196	4327	4604	4327
query23	34509	33507	33172	33172
query24	8322	2449	2441	2441
query25	599	439	402	402
query26	1214	277	147	147
query27	2720	488	326	326
query28	4359	2420	2365	2365
query29	759	531	415	415
query30	228	188	158	158
query31	956	816	780	780
query32	106	63	59	59
query33	542	387	298	298
query34	784	855	506	506
query35	820	801	707	707
query36	969	975	870	870
query37	116	113	79	79
query38	4271	4194	4116	4116
query39	1426	1380	1386	1380
query40	200	110	124	110
query41	52	56	48	48
query42	122	104	99	99
query43	489	508	472	472
query44	1289	793	798	793
query45	175	172	163	163
query46	861	1062	630	630
query47	1759	1782	1714	1714
query48	367	413	302	302
query49	770	496	391	391
query50	681	729	399	399
query51	4169	4214	4123	4123
query52	105	101	94	94
query53	221	246	183	183
query54	478	463	401	401
query55	79	78	76	76
query56	266	257	245	245
query57	1133	1131	1094	1094
query58	243	253	237	237
query59	2732	2763	2565	2565
query60	295	265	267	265
query61	117	120	115	115
query62	827	719	674	674
query63	226	190	184	184
query64	4404	1004	661	661
query65	3212	3137	3091	3091
query66	1166	408	296	296
query67	15690	15482	15392	15392
query68	5209	784	516	516
query69	468	293	263	263
query70	1219	1137	1119	1119
query71	457	294	268	268
query72	5609	3608	3746	3608
query73	741	726	353	353
query74	9150	9108	9055	9055
query75	3162	3170	2690	2690
query76	3284	1160	736	736
query77	459	369	271	271
query78	9960	10113	9338	9338
query79	2160	821	605	605
query80	1585	554	450	450
query81	586	276	230	230
query82	406	155	124	124
query83	275	168	149	149
query84	254	103	75	75
query85	855	350	329	329
query86	379	312	291	291
query87	4556	4517	4386	4386
query88	2881	2227	2206	2206
query89	393	389	283	283
query90	1737	193	195	193
query91	138	137	110	110
query92	64	63	54	54
query93	1245	1009	584	584
query94	667	392	299	299
query95	353	256	252	252
query96	483	554	265	265
query97	2794	2822	2722	2722
query98	222	205	201	201
query99	1334	1367	1286	1286
Total cold run time: 269146 ms
Total hot run time: 184046 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.26 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit bd8169b06c7c5d626cc62897a7209a64cc690d4a, data reload: false

query1	0.07	0.03	0.03
query2	0.07	0.03	0.04
query3	0.24	0.07	0.07
query4	1.63	0.10	0.11
query5	0.42	0.41	0.40
query6	1.16	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.61	0.51	0.54
query10	0.58	0.59	0.59
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.60	0.61	0.61
query14	2.69	2.71	2.71
query15	0.91	0.86	0.84
query16	0.40	0.37	0.37
query17	0.98	0.98	1.01
query18	0.22	0.20	0.20
query19	1.88	1.75	1.95
query20	0.02	0.02	0.02
query21	15.35	0.89	0.52
query22	0.75	1.21	0.67
query23	14.93	1.37	0.62
query24	6.82	2.34	0.67
query25	0.51	0.25	0.07
query26	0.54	0.17	0.13
query27	0.05	0.05	0.05
query28	9.36	0.84	0.43
query29	12.57	3.92	3.25
query30	0.24	0.08	0.06
query31	2.83	0.58	0.39
query32	3.22	0.56	0.47
query33	2.96	3.01	3.02
query34	15.81	5.12	4.46
query35	4.48	4.52	4.53
query36	0.67	0.50	0.50
query37	0.10	0.06	0.07
query38	0.06	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.14	0.12
query41	0.09	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.44 s
Total hot run time: 30.26 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit ce86935 into apache:master Feb 17, 2025
25 of 26 checks passed
@englefly englefly deleted the topn-filter-ratio branch February 17, 2025 09:56
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@englefly @lzyy2024
[fix](regression) topn-filter unstable case (apache#47797)
0284ae7 
### What problem does this PR solve?
regression-test/suites/query_p0/test_array_orderby_limit.groovy is
unstable
when case failed, plan shows that the table row count is 0.


Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
@morrySnow morrySnow mentioned this pull request Feb 28, 2025
Merged
16 tasks
dataroaring pushed a commit that referenced this pull request Mar 10, 2025
@englefly
branch 3.0: [fix](regression) topn-filter unstable case #47797 (#48367)
e531acb 
### What problem does this PR solve?
Pick #47797
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@LiBinfeng-01 LiBinfeng-01 LiBinfeng-01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@englefly @doris-robot @BiteTheDDDDt @LiBinfeng-01 @dataroaring @morrySnow