Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect attribute assignment in BROADCAST strategy of AbstractHttpSinkHandler #5177

Open
2 of 3 tasks
cnzakii opened this issue Feb 7, 2025 · 0 comments
Open
2 of 3 tasks
Labels
bug Something isn't working good first issue Issues for first-time contributors

Comments

@cnzakii
Copy link
Member

cnzakii commented Feb 7, 2025

Search before asking

  • I had searched in the issues and found no similar issues.

Environment

Mac

EventMesh version

master

What happened

In the BROADCAST strategy of AbstractHttpSinkHandler, the attributes map is updated within the loop instead of being assigned once before the loop. This causes a logic error that may prevent the callback operation from executing properly.

Expected behavior:

The attributes.put(MultiHttpRequestContext.NAME, new MultiHttpRequestContext(urls.size())) statement should be placed outside the loop to ensure that the attribute is set only once, rather than being overwritten in each iteration.

Image

How to reproduce

None

Debug logs

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@cnzakii cnzakii added bug Something isn't working good first issue Issues for first-time contributors labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Issues for first-time contributors
Projects
None yet
Development

No branches or pull requests

1 participant