Skip to content

Commit b07b579

Browse files
committed
Fix tests according to ad-hoc fix of KBinsDiscretizer.
1 parent 4544400 commit b07b579

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

flink-ml-lib/src/test/java/org/apache/flink/ml/common/gbt/PreprocessTest.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ public void testPreprocessCols() throws Exception {
143143
// TODO: correct `binEdges` of feature `f0` after FLINK-30734 resolved.
144144
List<FeatureMeta> expectedMeta =
145145
Arrays.asList(
146-
FeatureMeta.continuous("f0", 3, new double[] {1.2, 4.5, 13.9, Double.NaN}),
146+
FeatureMeta.continuous("f0", 3, new double[] {1.2, 4.5, 13.9, 15.3}),
147147
FeatureMeta.continuous("f1", 3, new double[] {1.0, 2.0, 4.0, 5.0}),
148148
FeatureMeta.categorical("f2", 5, new String[] {"a", "b", "c", "d", "e"}));
149149

@@ -154,7 +154,7 @@ public void testPreprocessCols() throws Exception {
154154
Row.of(40.0, 0, 2, 2.0),
155155
Row.of(40.0, 1, 2, 0.0),
156156
Row.of(40.0, 1, 1, 1.0),
157-
Row.of(41.0, 2, 1, 2.0),
157+
Row.of(41.0, 3, 1, 2.0),
158158
Row.of(41.0, 1, 2, 4.0),
159159
Row.of(41.0, 2, 1, 1.0),
160160
Row.of(41.0, 2, 2, 0.0),
@@ -188,19 +188,17 @@ public void testPreprocessVectorCol() throws Exception {
188188
// TODO: correct `binEdges` of feature `_vec_f0` and `_vec_f2` after FLINK-30734 resolved.
189189
List<FeatureMeta> expectedMeta =
190190
Arrays.asList(
191-
FeatureMeta.continuous(
192-
"_vec_f0", 3, new double[] {1.2, 4.5, 13.9, Double.NaN}),
191+
FeatureMeta.continuous("_vec_f0", 3, new double[] {1.2, 4.5, 13.9, 15.3}),
193192
FeatureMeta.continuous("_vec_f1", 3, new double[] {1.0, 2.0, 4.0, 5.0}),
194-
FeatureMeta.continuous(
195-
"_vec_f2", 3, new double[] {1.0, 2.0, 3.0, Double.NaN}));
193+
FeatureMeta.continuous("_vec_f2", 3, new double[] {1.0, 2.0, 3.0, 5.0}));
196194
List<Row> expectedPreprocessedRows =
197195
Arrays.asList(
198-
Row.of(40.0, Vectors.dense(0, 1, 2.0)),
196+
Row.of(40.0, Vectors.dense(0, 1, 3.0)),
199197
Row.of(40.0, Vectors.dense(0, 1, 1.0)),
200198
Row.of(40.0, Vectors.dense(0, 2, 2.0)),
201199
Row.of(40.0, Vectors.dense(1, 2, 0.0)),
202200
Row.of(40.0, Vectors.dense(1, 1, 1.0)),
203-
Row.of(41.0, Vectors.dense(2, 1, 2.0)),
201+
Row.of(41.0, Vectors.dense(3, 1, 2.0)),
204202
Row.of(41.0, Vectors.dense(1, 2, 2.0)),
205203
Row.of(41.0, Vectors.dense(2, 1, 1.0)),
206204
Row.of(41.0, Vectors.dense(2, 2, 0.0)),

0 commit comments

Comments
 (0)