[FLINK-38754][runtime] Avoid reverse DNS lookups when connecting to BlobServer #27318
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
davidradl
reviewed
Dec 4, 2025
| // InetSocketAddress can cache a failure in hostname resolution forever. | ||
| socket.connect( | ||
| new InetSocketAddress(serverAddress.getHostName(), serverAddress.getPort()), | ||
| new InetSocketAddress(serverAddress.getHostString(), serverAddress.getPort()), |
Contributor
There was a problem hiding this comment.
The change looks good. nit: I wonder if we could add a comment to explain why we do. not use getHostName. Maybe include some of the following reasons: Addresses are often configured as IP addresses for reliability
DNS may be unavailable or slow in containerized/cloud environments
Every blob transfer would trigger unnecessary reverse DNS lookups
Connection failures could occur if DNS resolution fails
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion! I’ve updated the code comment to explain the reason.
davidradl
approved these changes
Dec 4, 2025
davidradl
approved these changes
Dec 4, 2025
github-actions
bot
added
the
community-reviewed
Contributor
Author
|
@flinkbot run azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The goal of this pull request is to avoid reverse DNS lookups when TaskManager connects to BlobServer.
Brief change log
Use InetSocketAddress#getHostString instead of InetSocketAddress#getHostName to avoid reverse DNS lookups.
Verifying this change
This change is already covered by existing tests, such as BlobClientTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation