Skip to content

Commit 56f7b47

Browse files
fixed test case
1 parent 42105cf commit 56f7b47

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1051,7 +1051,7 @@ public class ConfigurationKeys {
10511051
public static final String GAAS_JOB_EXEC_ID = "gaas.job.execid";
10521052

10531053
// Configuration Key for storing hash of gaas.job.execid, to be used as jobExecutionId(integer) for backwards compatibility
1054-
public static final String GAAS_JOB_EXEC_ID_HASH = "gaas.job.execid.hash";
1054+
public static final String GAAS_JOB_EXEC_ID_HASH = "gaas.job.executionid.hash";
10551055

10561056
public static final String AZKABAN_URL = "azkaban.link.execution.url";
10571057
public static final String AZKABAN_FLOW_URL = "azkaban.link.workflow.url";

gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/DagProcUtilsTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
import org.apache.gobblin.service.modules.orchestration.DagManagementStateStore;
4545
import org.apache.gobblin.service.modules.orchestration.DagManagerMetrics;
4646
import org.apache.gobblin.service.modules.spec.JobExecutionPlan;
47+
import org.apache.gobblin.util.ConfigUtils;
4748
import org.mockito.Mockito;
4849
import org.testng.Assert;
4950
import org.testng.annotations.BeforeMethod;
@@ -91,8 +92,8 @@ public void testGaaSJobExecutionIdInjection() throws URISyntaxException, IOExcep
9192
DagProcUtils.submitNextNodes(dagManagementStateStore, dag, dagId);
9293
// Assertion to test that GaaS job execution Id has been successfully injected
9394
for(JobExecutionPlan jobExecutionPlan : jobExecutionPlans) {
94-
final String gaasJobExecutionId = jobExecutionPlan.getJobSpec().getConfig().getString(ConfigurationKeys.GAAS_JOB_EXEC_ID);
95-
final Long gaasJobExecutionIdHash = Long.parseLong(jobExecutionPlan.getJobSpec().getConfig().getString(ConfigurationKeys.GAAS_JOB_EXEC_ID_HASH));
95+
final String gaasJobExecutionId = ConfigUtils.getString(jobExecutionPlan.getJobSpec().getConfig(),ConfigurationKeys.GAAS_JOB_EXEC_ID,"");
96+
final Long gaasJobExecutionIdHash = Long.parseLong(ConfigUtils.getString(jobExecutionPlan.getJobSpec().getConfig(),ConfigurationKeys.GAAS_JOB_EXEC_ID_HASH,""));
9697

9798
Assert.assertNotNull(gaasJobExecutionId);
9899
Assert.assertEquals(gaasJobExecutionId.length(), 36);

0 commit comments

Comments
 (0)