HADOOP-19610. S3A: ITests to run under JUnit5 #7814
+267
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* junit.jupiter and junit.vintage => 5.13.3 * junit.platform => 1.13.3 * Surefire => 3.5.3. Without that tests weren't being found. * cut a duplicate and conflicting import of mockito-jupiter; maven was warning of this.
pick up changes of apache#5567 to pull out setting of stack trace and failIfNoSpecifiedTests to build properties with our chosen values.
|
Seems to kick off the tests in parallel. There are three runs, the last with no tests executed. But its elapsed time is exactly those of the other two executions added up (16.38 + 12.42 |
|
comparison execution time note that both test runs were in a single process, so even if the log showed three test suites running at the same time, only one process is running I don't think that is good, because we do have shared state (filesystem cache etc) which will interfere with each other |
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
changed the title
These map to "flaky", "rootfilesystem" and "scale" Junit 5 tags.
Goals
-can control which tests are run
-tests which are flaky due to external factors like network underflow
can be skipped by CI builds.
Add Class attribute @ParamString, where goal is to provide a string
of the formatted parameterized values.
@ParamString("performance-%s")
There's no implementation of this (yet); may need a different way
of doing it later. Goal is to make it possible to use in path names.
JUnit4 methodName did this, but I am not sure about JUnit 5
...this is a placeholder.
ITestS3AContractSeek is class parameterized.
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing parameterized ITests in hadoop-aws to work under Junit 5.
This is on top of PR #7785
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?