From 490883597d17b504a94f3ba3d267a6d8217280ff Mon Sep 17 00:00:00 2001 From: Ray Mattingly Date: Tue, 28 Jan 2025 15:28:39 -0500 Subject: [PATCH] HBASE-29073 StochasticLoadBalancer will always run the balancer on startup because of uninitialized sumMultiplier (#6641) Co-authored-by: Ray Mattingly Signed-off-by: Nick Dimiduk --- .../hbase/master/balancer/StochasticLoadBalancer.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java index 4b7a23c0eb2c..31d02fa71d6e 100644 --- a/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java +++ b/hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java @@ -421,13 +421,16 @@ boolean needsBalance(TableName tableName, BalancerClusterState cluster) { } double total = 0.0; + float localSumMultiplier = 0; // in case this.sumMultiplier is not initialized for (CostFunction c : costFunctions) { if (!c.isNeeded()) { LOG.trace("{} not needed", c.getClass().getSimpleName()); continue; } total += c.cost() * c.getMultiplier(); + localSumMultiplier += c.getMultiplier(); } + sumMultiplier = localSumMultiplier; boolean balanced = (total / sumMultiplier < minCostNeedBalance); if (balanced) { @@ -536,12 +539,13 @@ protected List balanceTable(TableName tableName, initCosts(cluster); - sumMultiplier = 0; + float localSumMultiplier = 0; for (CostFunction c : costFunctions) { if (c.isNeeded()) { - sumMultiplier += c.getMultiplier(); + localSumMultiplier += c.getMultiplier(); } } + sumMultiplier = localSumMultiplier; if (sumMultiplier <= 0) { LOG.error("At least one cost function needs a multiplier > 0. For example, set " + "hbase.master.balancer.stochastic.regionCountCost to a positive value or default");