[Bug]: hitting OK in transforms does sometimes not apply the changes

[gmitter-ef]

Apache Hop version?

2.12.0, 2.13.0-snapshot

Java version?

OpenJDK 17

Operating system

Windows

What happened?

• choose default project
• create a new pipeline
• add a "Data grid" transform
• add a field "test" of type "String" and enter "A" as data
• rename the Data grid to e.g. "test" (not sure if renaming is actually necessary for the bug exposal!)
• save the file
• Repeat the following steps:
  ** edit the Data grid
  ** delete value "A" for field "test"
  ** hit "OK"
  ** save the file
  ** edit the Data grid
  ** enter value "A" for field "test
  ** hit "OK"
  ** save the file

At some point in time, the file does not get bold after hitting OK, and the changes you made are not applied!!!

This is a bug that applies to all kinds of transforms, and is hard to reproduce, but extremely annoying.
NOTE: this seems to have been introduced in 2.12.0., until 2.11.0 this was never experienced.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

[enjoyy2]

i can confirm also the behavior. i am experiencing this also at version 2.8.0. its very annoying when we are doing a lot of changes and loosing them just with a click of a button.

[sramazzina]

Hi @gmitter-ef you suggested to use DataGrig transform because you are experiencing the issue on that transform only? Can you give us a wider view if the problem? The problem you are experiencing is related with events handled by any visual component (with this term I mean any component in Hop that has a gui so for example transforms, actions and so on). That said I'm asking you about that because it could be an issue related only with the way the DataGrid component handle GUI events.

[gmitter-ef]

Hi @sramazzina! No, it is a problem that is NOT restricted to DataGrid transform only, I only chose DataGrid because there it was rather simple to reproduce the issue.

[bamaer]

@gmitter-ef @enjoyy2 just tried 15-20 times to reproduce the issue (on MacOS, not Windows), but I assume @sramazzina woul have encountered this on Windows too if it was easy to reproduce.
The more information you can provide to reproduce this, the better. Without a clear reproduction path, I'm afraid we're in the dark on this.

[hansva]

I know we also have listeners to see if files have changed on the file system and then reload the file. So I am wondering if you are storing your pipelines/workflows on a network backed location? OneDrive or a NAS mount or a synced home folder?

[gmitter-ef]

@bamaer Hi, I just used a fresh installation of 2.13 and reproduced it again under Windows 11. Both deleting the value as well as entering it sometimes does not apply the change, and the file name tab does not get bold.

In 25 consecutive editing steps (either entering or deleting the value "A") the issue occured on the 5th, 16th and 24th time.

[gmitter-ef]

I know we also have listeners to see if files have changed on the file system and then reload the file. So I am wondering if you are storing your pipelines/workflows on a network backed location? OneDrive or a NAS mount or a synced home folder?

No, everything on the regular file system, C:\apache-hop-client-2.13.0\hop

[gmitter-ef]

Do not know if it helps a lot, but the "JavaScript" transform is definitely also affected, the changes seem to be a little more frequently not applied than in the Data grid.

• Change "Type" from "String" to "Integer" and back some times
• Change " = 'bla';" to " = 'xyz';" some times.
  In 25 changes 4 times the change was not applied.

Also selecting the code with the mouse, hitting "Delete" and then clicking OK loses the modification regularly.

[enjoyy2]

i am getting the same behavior as gmitter-ef on multiple transforms since 2.8.0, formula, java transform, select values, create json, i select some fields then hit ok, when i enter again their are not selected, even with select values transform. also i am on regular file system. it's seems like hitting ok does not save the file with the new changes. sometimes i even hit ok, the pipeline name does not even highlight in bold as not being saved, but in fact it is already saved cause pressing ctrl+s does not do anything.

i developed a behavior to always save what i wrote in custom code or formula transforms to have it in the clipboard not to loose work. i also click around the canvas sometimes and move a transform a little and save the pipeline to avoid this behavior, sometimes works but not always. somehow something is stuck behind before trying to open a transform and edit it.

[hansva]

I know we also have listeners to see if files have changed on the file system and then reload the file. So I am wondering if you are storing your pipelines/workflows on a network backed location? OneDrive or a NAS mount or a synced home folder?

No, everything on the regular file system, C:\apache-hop-client-2.13.0\hop

And your project is in the same hop folder?

[hansva]

I was able to reproduce it.
now have to figure out what is happening