Revert not rewrite in binding

apache · Mar 11, 2024 · 665f47a · 665f47a
1 parent 0422f07
commit 665f47a
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/crates/iceberg/src/expr/predicate.rs b/crates/iceberg/src/expr/predicate.rs
@@ -245,8 +245,13 @@ impl Bind for Predicate {
                 })
             }
             Predicate::Not(expr) => {
-                let [inner] = expr.inputs;
-                inner.negate().bind(schema, case_sensitive)
+                let bound_expr = expr.bind(schema, case_sensitive)?;
+                let [inner] = bound_expr.inputs;
+                Ok(match inner {
+                    e if matches!(&*e, &BoundPredicate::AlwaysTrue) => BoundPredicate::AlwaysFalse,
+                    e if matches!(&*e, &BoundPredicate::AlwaysFalse) => BoundPredicate::AlwaysTrue,
+                    e => BoundPredicate::Not(LogicalExpression::new([e])),
+                })
             }
             Predicate::Or(expr) => {
                 let bound_expr = expr.bind(schema, case_sensitive)?;
@@ -847,7 +852,7 @@ mod tests {
         let schema = table_schema_simple();
         let expr = !Reference::new("bar").less_than(Datum::int(10));
         let bound_expr = expr.bind(schema, true).unwrap();
-        assert_eq!(&format!("{bound_expr}"), "bar >= 10");
+        assert_eq!(&format!("{bound_expr}"), "NOT (bar < 10)");
     }
 
     #[test]