Skip to content

Commit

Permalink
chore: fix edition 2024 compile errors (#998)
Browse files Browse the repository at this point in the history
Signed-off-by: xxchan <[email protected]>
  • Loading branch information
xxchan authored Feb 24, 2025
1 parent 0c60c10 commit 8fd343d
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions crates/iceberg/src/arrow/record_batch_transformer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,8 +140,8 @@ impl RecordBatchTransformer {
Ok(match &self.batch_transform {
Some(BatchTransform::PassThrough) => record_batch,
Some(BatchTransform::Modify {
ref target_schema,
ref operations,
target_schema,
operations,
}) => {
let options = RecordBatchOptions::default()
.with_match_field_names(false)
Expand Down Expand Up @@ -294,7 +294,7 @@ impl RecordBatchTransformer {
Error::new(ErrorKind::Unexpected, "Field not found in snapshot schema")
)?;

let default_value = if let Some(ref iceberg_default_value) =
let default_value = if let Some(iceberg_default_value) =
&iceberg_field.initial_default
{
let Literal::Primitive(primitive_literal) = iceberg_default_value else {
Expand Down
6 changes: 3 additions & 3 deletions crates/iceberg/src/scan.rs
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ impl TableScan {

if let Some(ref bound_predicates) = manifest_entry_context.bound_predicates {
let BoundPredicates {
ref snapshot_bound_predicate,
ref partition_bound_predicate,
snapshot_bound_predicate,
partition_bound_predicate,
} = bound_predicates.as_ref();

let expression_evaluator_cache =
Expand Down Expand Up @@ -733,7 +733,7 @@ impl PlanContext {
manifest_list: Arc<ManifestList>,
tx_data: Sender<ManifestEntryContext>,
delete_file_idx_and_tx: Option<(DeleteFileIndex, Sender<ManifestEntryContext>)>,
) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>>>> {
) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>> + 'static>> {
let manifest_files = manifest_list.entries().iter();

// TODO: Ideally we could ditch this intermediate Vec as we return an iterator.
Expand Down

0 comments on commit 8fd343d

Please sign in to comment.