From 97411cc234ca8c430a119490e4c9a4904836d635 Mon Sep 17 00:00:00 2001
From: xxchan <xxchan22f@gmail.com>
Date: Sun, 23 Feb 2025 22:02:07 +0800
Subject: [PATCH] chore: fix edition 2024 compile errors

Signed-off-by: xxchan <xxchan22f@gmail.com>
---
 .../iceberg/src/arrow/record_batch_transformer.rs   |  6 +++---
 crates/iceberg/src/scan.rs                          | 13 +++++++------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/crates/iceberg/src/arrow/record_batch_transformer.rs b/crates/iceberg/src/arrow/record_batch_transformer.rs
index 9a4dd1784..38543509b 100644
--- a/crates/iceberg/src/arrow/record_batch_transformer.rs
+++ b/crates/iceberg/src/arrow/record_batch_transformer.rs
@@ -140,8 +140,8 @@ impl RecordBatchTransformer {
         Ok(match &self.batch_transform {
             Some(BatchTransform::PassThrough) => record_batch,
             Some(BatchTransform::Modify {
-                ref target_schema,
-                ref operations,
+                target_schema,
+                operations,
             }) => {
                 let options = RecordBatchOptions::default()
                     .with_match_field_names(false)
@@ -294,7 +294,7 @@ impl RecordBatchTransformer {
                     Error::new(ErrorKind::Unexpected, "Field not found in snapshot schema")
                 )?;
 
-                let default_value = if let Some(ref iceberg_default_value) =
+                let default_value = if let Some(iceberg_default_value) =
                     &iceberg_field.initial_default
                 {
                     let Literal::Primitive(primitive_literal) = iceberg_default_value else {
diff --git a/crates/iceberg/src/scan.rs b/crates/iceberg/src/scan.rs
index 30e45a074..3ad9f0487 100644
--- a/crates/iceberg/src/scan.rs
+++ b/crates/iceberg/src/scan.rs
@@ -509,8 +509,8 @@ impl TableScan {
 
         if let Some(ref bound_predicates) = manifest_entry_context.bound_predicates {
             let BoundPredicates {
-                ref snapshot_bound_predicate,
-                ref partition_bound_predicate,
+                snapshot_bound_predicate,
+                partition_bound_predicate,
             } = bound_predicates.as_ref();
 
             let expression_evaluator_cache =
@@ -733,7 +733,7 @@ impl PlanContext {
         manifest_list: Arc<ManifestList>,
         tx_data: Sender<ManifestEntryContext>,
         delete_file_idx_and_tx: Option<(DeleteFileIndex, Sender<ManifestEntryContext>)>,
-    ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>>>> {
+    ) -> Result<Box<impl Iterator<Item = Result<ManifestFileContext>> + 'static>> {
         let manifest_files = manifest_list.entries().iter();
 
         // TODO: Ideally we could ditch this intermediate Vec as we return an iterator.
@@ -1392,9 +1392,10 @@ pub mod tests {
             let values: BooleanArray = values.into();
             let col8 = Arc::new(values) as ArrayRef;
 
-            let to_write = RecordBatch::try_new(schema.clone(), vec![
-                col1, col2, col3, col4, col5, col6, col7, col8,
-            ])
+            let to_write = RecordBatch::try_new(
+                schema.clone(),
+                vec![col1, col2, col3, col4, col5, col6, col7, col8],
+            )
             .unwrap();
 
             // Write the Parquet files