Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Improve efficiency of Docker fixtures in integration_tests #923

Open
gruuya opened this issue Jan 29, 2025 · 1 comment · May be fixed by #924
Open

chore: Improve efficiency of Docker fixtures in integration_tests #923

gruuya opened this issue Jan 29, 2025 · 1 comment · May be fixed by #924

Comments

@gruuya
Copy link
Contributor

gruuya commented Jan 29, 2025

The goal of this issue would be to improve the following

  1. Currently each integration test relies on separate docker containers, meaning there's some time being lost starting/stopping (and building) containers for each test individually.
    • this doesn't seem strictly required, as most or even all present integration tests can be run on the same set of containers
    • moreover, sharing the same set of containers means tests could be run concurrently (they're run sequentially atm)
  2. A corollary to 1 is that adding multiple tests which call set_test_fixture into the same file is not reliable as there are docker container port races ongoing

Presumably at some point there might be tests that actually change something which other tests shouldn't observe, so the ideal solution would allow for having a separate set of containers for those tests alone, and shared ones for all the rest.

@gruuya gruuya linked a pull request Jan 30, 2025 that will close this issue
@gruuya
Copy link
Contributor Author

gruuya commented Jan 30, 2025

One proposal for how to resolve this is #924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant