-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support commit retrie #964
Comments
Thanks @ZENOTME for raising this. The core part of commit of conflict detection for different isolation levels, which is quite hard to implement correctly. Retry itself is not a big problem, it's just a reload of table metadata and do conflict detection. I'm not familiar with |
Thanks @liurenjie1024. I will take some effort to investigate more about conflict detection. |
Hi, I take some time to figure out the whole commit process. The whole commit phase can be described as follows:
For now, we only support FastAppend. So we can complete the whole process based on the FastAppend first and complete conflict detection when we introduce other update actions. How do you think? @liurenjie1024 |
This sounds reasonable to me. |
Let's move. I will work on this later |
I would like to separate this task into multiple steps:
We can introduce a new
ErrorKind::RetryableCommitError
to abstract kinds of catalog errors.About the retry library, personally, I think https://github.com/Xuanwo/backon can be a good candidate. Its maintainer is @Xuanwo. (Thanks for this great job!)
Welcome more suggestions and elaborations. cc @Fokko @Xuanwo @liurenjie1024 @sdd
The text was updated successfully, but these errors were encountered: