Hive: Metadata integrity check for encrypted tables #14685
Merged
+287
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ggershinsky this is regarding our discussion at #13225 (comment) Let me know if you think this approach is right, then I'll work on the finishing touches and tests. |
Contributor
|
Thanks @szlta , this approach looks good to me. |
ggershinsky
reviewed
Nov 27, 2025
hive-metastore/src/main/java/org/apache/iceberg/hive/HMSTablePropertyHelper.java
Outdated
Show resolved
Hide resolved
szlta
force-pushed
the
hive_integrity_check
branch
from
b170f1a to
9afe8ff
Compare
szlta
changed the title
ggershinsky
reviewed
Dec 4, 2025
| public void close() throws IOException {} | ||
|
|
||
| public byte[] getHash() { | ||
| return digest.digest(); |
Contributor
There was a problem hiding this comment.
nit: an exception if not closed?
Contributor
Author
There was a problem hiding this comment.
You're right, it's needed as calling digest() will cause a reset in MessageDigest internal state and further calls will produce a wrong value. I've added a closing logic now.
Introducing new Hive table property metadata_hash (to be stored exclusively in HMS) that tracks the hash of the current table metadata. It is used in HiveTableOperations to carry out integrity check and ensure that the metadata.json has not been tampered with when table encryption is used.
Change-Id: I72dad6d8dbc2338299236e495bc76ba60fab7db8
Change-Id: Ie8d978b022ab67bfa3b3238ebc3c5d4f25d0a843
szlta
force-pushed
the
hive_integrity_check
branch
from
67b209e to
e614a79
Compare
Contributor
|
cc @huaxingao |
huaxingao
reviewed
Dec 8, 2025
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
Outdated
Show resolved
Hide resolved
huaxingao
approved these changes
Dec 8, 2025
Change-Id: Ie5a0310a1b2eb71ed171c1eaa4c4529ada136565
Contributor
|
Thanks @szlta for the PR! Thanks @ggershinsky for the review! |
Contributor
Author
|
Thanks for review @ggershinsky and @huaxingao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing new Hive table property metadata_hash (to be stored exclusively in HMS) that tracks the hash of the current table metadata.
It is used in HiveTableOperations to carry out integrity check and ensure that the metadata.json has not been tampered with when table encryption is used.