feat(pagerduty): add scope config filters for incident collection #8603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
dosubot
bot
added
size:XS
dosubot
bot
added
size:L
3 tasks
klesh
reviewed
Oct 9, 2025
| "GET": api.GetScopeConfig, | ||
| "DELETE": api.DeleteScopeConfig, | ||
| }, | ||
| "scope-config/:scopeConfigId/projects": { |
Contributor
There was a problem hiding this comment.
Please change it to connections/:connectionId/scope-configs/:scopeConfigId/projects to comply RESTful convention.
Author
There was a problem hiding this comment.
Hello @klesh
I have a question, in other plugins: (bitbucket, github, gitlab, jira, trello, etc...) the path used is scope-config/:scopeConfigId/projects .
Let me know hoy to proceed.
Thanks for review this!.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pr-type/bug-fix,pr-type/feature-development, etc.Summary
This PR adds Priority and Urgency filtering capabilities to the PagerDuty plugin, allowing users to filter incidents during data collection based on their priority levels (P1-P5) and urgency (high/low).
Does this close any open issues?
Closes 8367
Screenshots
Other Information
This is my first PR to Devlake protect, please let me know if there is any extra documentation or test that need to be completed.
I test it using no filters and also using filter Priority=P1 and Urgency=High