Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NDEBUG macro when compile pegasus in release mode #102

Open
qinzuoyan opened this issue Jun 29, 2018 · 0 comments
Open

add NDEBUG macro when compile pegasus in release mode #102

qinzuoyan opened this issue Jun 29, 2018 · 0 comments
Labels
type/enhancement Indicates new feature requests

Comments

@qinzuoyan
Copy link
Contributor

now we use lots of assert() in our code, and do not add NDEBUG macro even when compile in release mode.

to improve:

  • add NDEBUG macro when compile pegasus in release mode
  • change necessary assert() to dassert()
  • test and compare performance with NDEBUG and without NDEBUG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qinzuoyan