Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to Google & Baidu Analytics from Seata Website #931

Open
niallkp opened this issue Feb 1, 2025 · 8 comments · Fixed by #937
Open

Remove references to Google & Baidu Analytics from Seata Website #931

niallkp opened this issue Feb 1, 2025 · 8 comments · Fixed by #937
Assignees
Labels
help wanted Extra attention is needed

Comments

@niallkp
Copy link
Contributor

niallkp commented Feb 1, 2025

Hi Seata Team!

We can see that you migrated to Matomo for analytics in March 2024 - thanks for doing that! However the Seata Website still seems to have references to Google & Baidu Analytics which causes it to be flagged on a monthly report to the Privacy Committee.

Please could you remove all references to Google & Baidu Analytics from your website?

Thanks
Niall

DOCUSAURUS branch scan

Searching for googletagmanager.com Found 4 occurrence(s) in 3 file(s)

  • 404.html
  • docusaurus.config.js
  • static/js/gtag.js

Searching for hm.baidu.com Found 3 occurrence(s) in 3 file(s)

  • docusaurus.config.js
  • src/custom-js.ts
  • static/js/hm.js

Searching for google-analytics.com Found 1 occurrence(s) in 1 file(s)

  • static/js/gtag.js

ASF-SITE branch scan

Searching for  **googletagmanager.com** Found 261 occurrence(s) in 257 file(s)
Searching for **hm.baidu.com** Found 256 occurrence(s) in 256 file(s)
Searching for **google-analytics.com** Found 4 occurrence(s) in 4 file(s)

The following table shows the counts of files containing googletagmanager.com and hm.baidu.com

Prefix or File Count of files containing googletagmanager Count of files containing Baidu
404.html 1
**/index.html 102 102
**/gtag.js 4
**/hm.js 4
assets/js/main* 44 44
build/assets/js/main* 44 44
build/zh-cn/assets/js/main* 31 31
zh-cn/assets/js/main* 31 31
Total 257 256

Below are the four files with references to google-analytics.com:

  • build/js/gtag.js
  • build/zh-cn/js/gtag.js
  • js/gtag.js
  • zh-cn/js/gtag.js
@slievrly
Copy link
Member

slievrly commented Feb 2, 2025

@niallkp Thank you very much for your feedback and we will remove these references in the near future to ensure privacy compliance.

@slievrly slievrly added the help wanted Extra attention is needed label Feb 2, 2025
@slievrly slievrly self-assigned this Feb 2, 2025
@slievrly slievrly reopened this Feb 6, 2025
@slievrly
Copy link
Member

slievrly commented Feb 6, 2025

@niallkp I have removed the reference of Google & Baidu Analytics, could you please help me recheck and confirm it?

@niallkp
Copy link
Contributor Author

niallkp commented Feb 6, 2025

It would make life easier if the analytics code was completely removed rather than just commenting it out. Scanning the asf-site branch produces the same hits as before - 257 files

Please see #938

@slievrly
Copy link
Member

slievrly commented Feb 7, 2025

@niallkp The above comment code submitted by PR is the first step to confirm whether it is valid, and then delete it if it is valid. Thank you very much for your submitted code, I have merged #938, CICD will regenerate the static page to asf-site branch and redeploy it. If you have time, please help recheck.

@niallkp
Copy link
Contributor Author

niallkp commented Feb 7, 2025

Thank you @slievrly, that helps identify whats left. It looks like you have a number of old pages which are no longer being updated/generated that still contain Ggogle & Baidu analytics. I suspect the pages probably should be removed, for example:

Anyway, I will submit a PR to remove Ggogle & Baidu analytics from those files:

@slievrly
Copy link
Member

slievrly commented Feb 8, 2025

Thank you @slievrly, that helps identify whats left. It looks like you have a number of old pages which are no longer being updated/generated that still contain Ggogle & Baidu analytics. I suspect the pages probably should be removed, for example:

Anyway, I will submit a PR to remove Ggogle & Baidu analytics from those files:

There are definitely some old pages that are no longer in use. Also, the Seata official website has changed its frontend framework, so the new static resources generated won't overwrite the old, unused files. A quick fix for this would be to just delete the asf-site branch and regenerate the static resources from scratch.

Thanks a lot for your code submission regarding this issue! I've merged it and triggered the GitHub action to generate the static resources again, ensuring that our overall process is on point.

@niallkp
Copy link
Contributor Author

niallkp commented Feb 8, 2025

All looks good to me now. Thank You @slievrly - much appreciated!

@slievrly
Copy link
Member

All looks good to me now. Thank You @slievrly - much appreciated!

Thank you very much for your solution as well. It is the implementation of your solution that has made it possible for Seata to comply with ASF's privacy policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants