KAFKA-19746 : Tools | Fix order of arguments to assertEquals in unit test (#20640)

In this PR, we corrected the argument order in assertEquals within the
tools package.

Reviewers: Ken Huang <[email protected]>, Andrew Schofield
<[email protected]>

---------

Co-authored-by: Abhi Tiwari <[email protected]>

Author: samarth-ksolves

tools/src/test/java/org/apache/kafka/tools/ConfigCommandTest.java

@@ -424,8 +424,8 @@ public void testParseConfigsToBeAddedForAddConfigFile() throws IOException {
     public void testExpectedEntityTypeNames(List<String> expectedTypes, List<String> expectedNames, List<String> connectOpts, String... args) {
         ConfigCommand.ConfigCommandOptions createOpts = new ConfigCommand.ConfigCommandOptions(toArray(List.of(connectOpts.get(0), connectOpts.get(1), "--describe"), List.of(args)));
         createOpts.checkArgs();
-        assertEquals(createOpts.entityTypes().toSeq(), seq(expectedTypes));
-        assertEquals(createOpts.entityNames().toSeq(), seq(expectedNames));
+        assertEquals(seq(expectedTypes), createOpts.entityTypes().toSeq());
+        assertEquals(seq(expectedNames), createOpts.entityNames().toSeq());
     }
 
     @Test
@@ -1177,8 +1177,8 @@ public void shouldNotUpdateConfigIfNonExistingConfigIsDeleted() {
             public synchronized DescribeConfigsResult describeConfigs(Collection<ConfigResource> resources, DescribeConfigsOptions options) {
                 assertEquals(1, resources.size());
                 ConfigResource res = resources.iterator().next();
-                assertEquals(res.type(), ConfigResource.Type.TOPIC);
-                assertEquals(res.name(), resourceName);
+                assertEquals(ConfigResource.Type.TOPIC, res.type());
+                assertEquals(resourceName, res.name());
                 return describeResult;
             }
         };

tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java

@@ -124,8 +124,8 @@ public void testDeprecatedAdminConfig() throws Exception {
             mockedAdmin.verify(() -> Admin.create(argumentCaptor.capture()));
             // verify that properties provided to admin client are the overridden properties
             final Properties actualProps = argumentCaptor.getValue();
-            assertEquals(actualProps.get(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG), requestTimeoutMs);
-            assertEquals(actualProps.get(AdminClientConfig.DEFAULT_API_TIMEOUT_MS_CONFIG), defaultApiTimeoutMs);
+            assertEquals(requestTimeoutMs, actualProps.get(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG));
+            assertEquals(defaultApiTimeoutMs, actualProps.get(AdminClientConfig.DEFAULT_API_TIMEOUT_MS_CONFIG));
         }
     }
 

tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java

@@ -909,7 +909,7 @@ private void resetAndAssertOffsetsCommitted(ClusterInstance cluster,
         Map<String, Map<TopicPartition, OffsetAndMetadata>> allResetOffsets = resetOffsets(service);
 
         allResetOffsets.forEach((group, offsetsInfo) -> offsetsInfo.forEach((tp, offsetMetadata) -> {
-            assertEquals(offsetMetadata.offset(), expectedOffsets.get(tp));
+            assertEquals(expectedOffsets.get(tp), offsetMetadata.offset());
             assertEquals(expectedOffsets, committedOffsets(cluster, topic, group));
         }));
     }

tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandTest.java

@@ -542,9 +542,9 @@ private static void assertThrow(final String wrongState) {
 
         final String[] exceptionMessage = exception.getMessage().split(" Valid states are: ");
         assertEquals("Invalid state list '" + wrongState + "'.", exceptionMessage[0]);
-        assertEquals(Arrays.stream(exceptionMessage[1].split(","))
+        assertEquals(validStates, Arrays.stream(exceptionMessage[1].split(","))
             .map(String::trim)
-            .collect(Collectors.toSet()), validStates);
+            .collect(Collectors.toSet()));
     }
 
     private DescribeStreamsGroupsResult describeStreamsResult(String groupId, GroupState groupState) {