Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pylint to increase code quality #55

Open
turbaszek opened this issue Oct 11, 2020 · 3 comments
Open

Introduce pylint to increase code quality #55

turbaszek opened this issue Oct 11, 2020 · 3 comments
Assignees
Labels

Comments

@turbaszek
Copy link
Member

Description
Introduce pylint for code quality analysis:
https://github.com/PyCQA/pylint

This can be easily done by adding a respectable hook to our pre-commit configuration. However, this may require a lot of changes to code and maybe better to split it into few commits in single PR.

Use case
Increase code quality, follow Python community best practices and avoid regression in future.

Related Issues
N/A

@michalslowikowski00
Copy link
Contributor

michalslowikowski00 commented Oct 17, 2020

I will do it.
Everyone loves quality. :)
https://www.youtube.com/watch?v=jbJ6Ufl5Kkc&ab_channel=MichaelFish

@michalslowikowski00
Copy link
Contributor

Ok, it will require more work, as you said.
Before submitting this PR'a I will fix the code to make it compliant with pylint: part by part.
There will be few PR's. :)

@turbaszek
Copy link
Member Author

@michalslowikowski00 the amount of work will depend on the number of errors. We can reduce them by adding more rules to ignored ones in pylintrc config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants