Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divide plugin Discovery Config, nacos service cannot be written in non default namespaces #5899

Open
1 task done
super-henry-bai opened this issue Jan 17, 2025 · 1 comment
Labels
type: bug Something isn't working

Comments

@super-henry-bai
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The Discovery Config feature of the Divde plugin cannot be written to Discovery Upstream when using nacos as the registry in a non default namespace.
The possible reason is that NacosDiscoveryService did not provide a namespaceId that can be passed in.

Image

Can the filtering in DiscoveryDataChangedEdSyncListener be removed.

Image

Expected Behavior

No response

Steps To Reproduce

Use Discovery Config in a non default namespace, with the type selected as nacos

Environment

ShenYu version(s):2.7.0

Debug logs

No response

Anything else?

No response

@super-henry-bai super-henry-bai added the type: bug Something isn't working label Jan 17, 2025
@Aias00
Copy link
Contributor

Aias00 commented Jan 20, 2025

hi, the namespaceId in filter, is not the nacos namespace。 it is shenyus new feature. the Discovery data should has its shenyu namepapceId. if not, will use default namespaceId, which is : org.apache.shenyu.common.constant.Constants#SYS_DEFAULT_NAMESPACE_ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants