Skip to content

Commit b390975

Browse files
authored
Remove 3 tonumber to erase the i64 not supported in Lua issue. (#11)
* Remove 3 `tonumber` to erase the i64 not supported in Lua issue. * Fix span test case * Fix segment ref test cases.
1 parent 95684f3 commit b390975

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

lib/skywalking/segment_ref_test.lua

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ TestSegmentRef = {}
2525
function TestSegmentRef:testFromSW6Value()
2626
local ref = SegmentRef:new():fromSW6Value('1-My40LjU=-MS4yLjM=-4-1-1-IzEyNy4wLjAuMTo4MDgw-Iy9wb3J0YWw=-MTIz')
2727
lu.assertNotNil(ref)
28-
lu.assertEquals(ref.trace_id, {3, 4, 5})
29-
lu.assertEquals(ref.segment_id, {1, 2, 3})
28+
lu.assertEquals(ref.trace_id, {"3", "4", "5"})
29+
lu.assertEquals(ref.segment_id, {"1", "2", "3"})
3030
lu.assertEquals(ref.span_id, 4)
3131
lu.assertEquals(ref.parent_service_instance_id, 1)
3232
lu.assertEquals(ref.entry_service_instance_id, 1)

lib/skywalking/span_test.lua

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,10 @@ TestSpan = {}
4848
lu.assertEquals(span1.layer, SpanLayer.NONE)
4949
local ref = span1.refs[1]
5050
lu.assertNotNil(ref)
51-
lu.assertEquals(ref.trace_id, {3, 4, 5})
51+
lu.assertEquals(ref.trace_id, {"3", "4", "5"})
5252
-- Context trace id will be overrided by the ref trace id
53-
lu.assertEquals(context.trace_id, {3, 4, 5})
54-
lu.assertEquals(ref.segment_id, {1, 2, 3})
53+
lu.assertEquals(context.trace_id, {"3", "4", "5"})
54+
lu.assertEquals(ref.segment_id, {"1", "2", "3"})
5555
lu.assertEquals(ref.span_id, 4)
5656
lu.assertEquals(ref.parent_service_instance_id, 1)
5757
lu.assertEquals(ref.entry_service_instance_id, 1)

lib/skywalking/util.lua

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ function _M.formatID(str)
9898
return nil
9999
end
100100

101-
parts[1] = tonumber(parts[1])
102-
parts[2] = tonumber(parts[2])
103-
parts[3] = tonumber(parts[3])
104-
105101
return parts
106102
end
107103

0 commit comments

Comments
 (0)