Skip to content

Commit f69e508

Browse files
committed
[SPARK-51039][BUILD] Fix hive-llap-common dependency to use hive.llap.scope in root pom.xml
### What changes were proposed in this pull request? This PR aims to fix `hive-llap-common` dependency to use `hive.llap.scope` in root pom for Apache Spark 3.5 and 4.0. ### Why are the changes needed? Apache Spark has been supposed to use `hive.llap.scope` for `hive-llap-common` dependency and `hive` module do it correctly. https://github.com/apache/spark/blob/a1b0f256c04e5b632075358d1e2f946e64588da6/sql/hive/pom.xml#L119-L123 Since Apache Spark 3.0.0 (SPARK-27176), the root `pom.xml` file has been using a wrong scope mistakenly. Probably, it's due to `-Phive-provided` support. This causes a confusion to other external systems and the users. We had better fix the root `pom.xml` to use `hive.llap.scope` correctly. - #23788 ### Does this PR introduce _any_ user-facing change? No, there is no change technically because `hive` module has been using a correct scope. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #49733 from dongjoon-hyun/SPARK-51039. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 7243de6) Signed-off-by: Dongjoon Hyun <[email protected]>
1 parent aedd9fc commit f69e508

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

assembly/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -323,6 +323,7 @@
323323
<id>hive-provided</id>
324324
<properties>
325325
<hive.deps.scope>provided</hive.deps.scope>
326+
<hive.llap.scope>provided</hive.llap.scope>
326327
<hive.jackson.scope>provided</hive.jackson.scope>
327328
</properties>
328329
</profile>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2255,7 +2255,7 @@
22552255
<groupId>${hive.group}</groupId>
22562256
<artifactId>hive-llap-common</artifactId>
22572257
<version>${hive.version}</version>
2258-
<scope>${hive.deps.scope}</scope>
2258+
<scope>${hive.llap.scope}</scope>
22592259
<exclusions>
22602260
<exclusion>
22612261
<groupId>${hive.group}</groupId>

0 commit comments

Comments
 (0)