[REFACTOR][FFI] Phase out old VisitAttrs mechanism (#18106)

Author: tqchen

apps/hexagon_launcher/launcher_util.cc

@@ -47,7 +47,7 @@ std::string load_text_file(const std::string& file_name) {
   std::string buffer(file_size + 1, 0);
 
   in_file.read(&buffer[0], file_size);
-  return std::move(buffer);
+  return buffer;
 }
 
 void* load_binary_file(const std::string& file_name, void* buffer, size_t buffer_size) {

ffi/include/tvm/ffi/object.h

@@ -214,7 +214,6 @@ class Object {
   static constexpr int32_t _type_depth = 0;
   // extra fields used by plug-ins for attribute visiting
   // and structural information
-  static constexpr const bool _type_has_method_visit_attrs = true;
   static constexpr const bool _type_has_method_sequal_reduce = false;
   static constexpr const bool _type_has_method_shash_reduce = false;
   // The following functions are provided by macro

include/tvm/arith/int_solver.h

@@ -83,7 +83,6 @@ class IntGroupBoundsNode : public Object {
     hash_reduce(upper);
   }
 
-  static constexpr const bool _type_has_method_visit_attrs = false;
   static constexpr const bool _type_has_method_sequal_reduce = true;
   static constexpr const char* _type_key = "arith.IntGroupBounds";
   TVM_DECLARE_FINAL_OBJECT_INFO(IntGroupBoundsNode, Object);
@@ -174,7 +173,6 @@ class IntConstraintsNode : public Object {
     hash_reduce(relations);
   }
 
-  static constexpr const bool _type_has_method_visit_attrs = false;
   static constexpr const bool _type_has_method_sequal_reduce = true;
   static constexpr const char* _type_key = "arith.IntConstraints";
   TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsNode, Object);
@@ -240,7 +238,6 @@ class IntConstraintsTransformNode : public Object {
     hash_reduce(dst_to_src);
   }
 
-  static constexpr const bool _type_has_method_visit_attrs = false;
   static constexpr const bool _type_has_method_sequal_reduce = true;
   static constexpr const char* _type_key = "arith.IntConstraintsTransform";
   TVM_DECLARE_FINAL_OBJECT_INFO(IntConstraintsTransformNode, Object);