Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error handling is fit for purpose for AMS #116

Closed
tofu-rocketry opened this issue Feb 4, 2020 · 1 comment
Closed

Check error handling is fit for purpose for AMS #116

tofu-rocketry opened this issue Feb 4, 2020 · 1 comment

Comments

@tofu-rocketry
Copy link
Member

It may be necessary to catch IOError in addition to OSError in on_message as there is no real difference between them and we sometimes get the former being raised, but we need to sort out how we acknowledge messages we pull from AMS otherwise we end up in a loop of continually trying to pull down the same message.

This issue was fixed for the original style of messaging in #63 but didn't get carried over for AMS messaging. (There's a large section that should be factored out for both types of messaging to avoid issues like this!)

Should also rename error to e to match on_message convention to simplify refactoring later.

@tofu-rocketry
Copy link
Member Author

Seems to have been superseded by the refactoring.

@tofu-rocketry tofu-rocketry closed this as not planned Won't fix, can't repro, duplicate, stale Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant