Varnish with GraphQl

[CvekCoding]

Good morning.

I found that in a case of GraphQl request Api-Platform doesn't add http headers (even if it's a GET request):

core/src/HttpCache/EventListener/AddHeadersListener.php

Lines 43 to 48 in 4dacd1a

	public function onKernelResponse(FilterResponseEvent $event)
	{
	$request = $event->getRequest();
	if (!$request->isMethodCacheable() || !RequestAttributesExtractor::extractAttributes($request)) {
	return;
	}

It's because the second check RequestAttributesExtractor::extractAttributes($request) returns empty array. Am I doing something wrong or it's a bug?

[CvekCoding]

Or simply http cache doesn't work for GraphQl yet?

[dunglas]

It's not done because it may be dangerous. You can take a look at the conference I did about that: https://speakerdeck.com/dunglas/rest-vs-graphql-illustrated-examples-with-the-api-platform-framework

[alanpoulain]

See also: #2134

[CvekCoding]

@dunglas , I understand that to cache GraphQl's responses we have to consider all the related entities (at least classes) in each particular request, to be able to cache and invalidate them.
But in real production environment it's a good thing to limit request by names. So the client will not be able to send arbitrary query, but only one of the allowed. And backend will determine these queries by their names, fetch real GraphQl query string from DB and send it to GraphQl endpoint.
I think it's possible to store metadata near of each query, in the similar way like you do this in RequestAttributesExtractor::extractAttributes($request) method.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.