chore: better PHP types (#4886)

Author: alanpoulain

CallableProcessor.php

@@ -26,25 +26,23 @@ public function __construct(private readonly ContainerInterface $locator)
     /**
      * {@inheritDoc}
      */
-    public function process($data, Operation $operation, array $uriVariables = [], array $context = [])
+    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = [])
     {
         if (!($processor = $operation->getProcessor())) {
-            return;
+            return null;
         }
 
         if (\is_callable($processor)) {
             return $processor($data, $operation, $uriVariables, $context);
         }
 
-        if (\is_string($processor)) {
-            if (!$this->locator->has($processor)) {
-                throw new RuntimeException(sprintf('Processor "%s" not found on operation "%s"', $processor, $operation->getName()));
-            }
+        if (!$this->locator->has($processor)) {
+            throw new RuntimeException(sprintf('Processor "%s" not found on operation "%s"', $processor, $operation->getName()));
+        }
 
-            /** @var ProcessorInterface */
-            $processor = $this->locator->get($processor);
+        /** @var ProcessorInterface $processorInstance */
+        $processorInstance = $this->locator->get($processor);
 
-            return $processor->process($data, $operation, $uriVariables, $context);
-        }
+        return $processorInstance->process($data, $operation, $uriVariables, $context);
     }
 }

CallableProvider.php

@@ -26,7 +26,7 @@ public function __construct(private readonly ContainerInterface $locator)
     /**
      * {@inheritDoc}
      */
-    public function provide(Operation $operation, array $uriVariables = [], array $context = [])
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|iterable|null
     {
         if (\is_callable($provider = $operation->getProvider())) {
             return $provider($operation, $uriVariables, $context);
@@ -37,10 +37,10 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
                 throw new RuntimeException(sprintf('Provider "%s" not found on operation "%s"', $provider, $operation->getName()));
             }
 
-            /** @var ProviderInterface */
-            $provider = $this->locator->get($provider);
+            /** @var ProviderInterface $providerInstance */
+            $providerInstance = $this->locator->get($provider);
 
-            return $provider->provide($operation, $uriVariables, $context);
+            return $providerInstance->provide($operation, $uriVariables, $context);
         }
 
         throw new RuntimeException(sprintf('Provider not found on operation "%s"', $operation->getName()));

Pagination/Pagination.php

@@ -221,10 +221,8 @@ private function getGraphQlEnabled(?Operation $operation): bool
 
     /**
      * Gets the given pagination parameter name from the given context.
-     *
-     * @param mixed|null $default
      */
-    private function getParameterFromContext(array $context, string $parameterName, $default = null)
+    private function getParameterFromContext(array $context, string $parameterName, mixed $default = null)
     {
         $filters = $context['filters'] ?? [];
 

ProcessorInterface.php

@@ -26,5 +26,5 @@ interface ProcessorInterface
     /**
      * Handle the state.
      */
-    public function process($data, Operation $operation, array $uriVariables = [], array $context = []);
+    public function process(mixed $data, Operation $operation, array $uriVariables = [], array $context = []);
 }

ProviderInterface.php

@@ -25,8 +25,6 @@ interface ProviderInterface
 {
     /**
      * Provides data.
-     *
-     * @return object|array|null
      */
-    public function provide(Operation $operation, array $uriVariables = [], array $context = []);
+    public function provide(Operation $operation, array $uriVariables = [], array $context = []): object|iterable|null;
 }

SerializerAwareProviderTrait.php

@@ -25,10 +25,8 @@ trait SerializerAwareProviderTrait
 {
     /**
      * @internal
-     *
-     * @var ContainerInterface
      */
-    private $serializerLocator;
+    private ContainerInterface $serializerLocator;
 
     public function setSerializerLocator(ContainerInterface $serializerLocator): void
     {
@@ -37,7 +35,6 @@ public function setSerializerLocator(ContainerInterface $serializerLocator): voi
 
     private function getSerializer(): SerializerInterface
     {
-        /* @var SerializerInterface */
         return $this->serializerLocator->get('serializer');
     }
 }