fix(state): improve DX around the generic ObjectProvider (#5051)

Author: chalasr

CreateProvider.php

@@ -13,6 +13,7 @@
 
 namespace ApiPlatform\State;
 
+use ApiPlatform\Exception\RuntimeException;
 use ApiPlatform\Metadata\Get;
 use ApiPlatform\Metadata\HttpOperation;
 use ApiPlatform\Metadata\Link;
@@ -58,8 +59,11 @@ public function provide(Operation $operation, array $uriVariables = [], array $c
         }
 
         $relation = $this->decorated->provide(new Get(uriVariables: $relationUriVariables, class: $relationClass), $uriVariables);
-        $refl = new \ReflectionClass($operation->getClass());
-        $resource = $refl->newInstanceWithoutConstructor();
+        try {
+            $resource = new ($operation->getClass());
+        } catch (\Throwable $e) {
+            throw new RuntimeException(sprintf('An error occurred while trying to create an instance of the "%s" resource. Consider writing your own "%s" implementation and setting it as `provider` on your operation instead.', $operation->getClass(), ProviderInterface::class), 0, $e);
+        }
         $this->propertyAccessor->setValue($resource, $key, $relation);
 
         return $resource;

ObjectProvider.php

@@ -13,10 +13,11 @@
 
 namespace ApiPlatform\State;
 
+use ApiPlatform\Exception\RuntimeException;
 use ApiPlatform\Metadata\Operation;
 
 /**
- * An ItemProvider that just create a new object.
+ * An ItemProvider that just creates a new object.
  *
  * @author Antoine Bluchet <[email protected]>
  *
@@ -26,8 +27,10 @@ final class ObjectProvider implements ProviderInterface
 {
     public function provide(Operation $operation, array $uriVariables = [], array $context = []): ?object
     {
-        $refl = new \ReflectionClass($operation->getClass());
-
-        return $refl->newInstanceWithoutConstructor();
+        try {
+            return new ($operation->getClass());
+        } catch (\Throwable $e) {
+            throw new RuntimeException(sprintf('An error occurred while trying to create an instance of the "%s" resource. Consider writing your own "%s" implementation and setting it as `provider` on your operation instead.', $operation->getClass(), ProviderInterface::class), 0, $e);
+        }
     }
 }